Merge branch 'enhancements/history-list-view' into enhancements/history-detail-tree-view

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs

@@ -35,8 +35,6 @@ public bool Render(Rect containingRect, Action<GitLogEntry> singleClick = null,
             Action<GitLogEntry> doubleClick = null, Action<GitLogEntry> rightClick = null)
         {
             var requiresRepaint = false;
-            var rect = Rect.zero;
-
             scroll = GUILayout.BeginScrollView(scroll);
             {
                 controlId = GUIUtility.GetControlID(FocusType.Keyboard);
@@ -54,7 +52,7 @@ public bool Render(Rect containingRect, Action<GitLogEntry> singleClick = null,
                 var startDisplay = scroll.y;
                 var endDisplay = scroll.y + containingRect.height;
 
-                rect = new Rect(containingRect.x, containingRect.y, containingRect.width, 0);
+                var rect = new Rect(containingRect.x, containingRect.y, containingRect.width, 0);
 
                 for (var index = 0; index < entries.Count; index++)
                 {
@@ -68,15 +66,15 @@ public bool Render(Rect containingRect, Action<GitLogEntry> singleClick = null,
                         RenderEntry(entryRect, entry, index);
                     }
 
-                    var entryRequiresRepaint = HandleInput(entryRect, entry, index, singleClick, doubleClick, rightClick);
+                    var entryRequiresRepaint =
+                        HandleInput(entryRect, entry, index, singleClick, doubleClick, rightClick);
                     requiresRepaint = requiresRepaint || entryRequiresRepaint;
 
                     rect.y += Styles.HistoryEntryHeight;
                 }
-            }
-
-            GUILayout.Space(rect.y - containingRect.y);
 
+                GUILayout.Space(rect.y - containingRect.y);
+            }
             GUILayout.EndScrollView();
 
             return requiresRepaint;
@@ -304,12 +302,6 @@ public void ScrollTo(int index, float offset = 0f)
         }
     }
 
-    enum LogEntryState
-    {
-        Normal,
-        Local
-    }
-
     [Serializable]
     class HistoryView : Subview
     {