We really don't want to call the finally handler twice

shana · shana · commit 05fafb506b05 · 2018-04-05T22:51:57.000+02:00
diff --git a/src/GitHub.Api/Tasks/TaskBase.cs b/src/GitHub.Api/Tasks/TaskBase.cs
@@ -671,7 +671,8 @@ protected virtual void RaiseOnEnd(TResult data)
         protected override void CallFinallyHandler()
         {
             finallyHandler?.Invoke(!taskFailed, result);
-            base.CallFinallyHandler();
+            if (finallyHandler == null)
+                base.CallFinallyHandler();
         }
 
         public new Task<TResult> Task

Original file line number	Diff line number	Diff line change
`@@ -671,7 +671,8 @@ protected virtual void RaiseOnEnd(TResult data)`
`671`	`671`	`protected override void CallFinallyHandler()`
`672`	`672`	`{`
`673`	`673`	`finallyHandler?.Invoke(!taskFailed, result);`
`674`		`- base.CallFinallyHandler();`
	`674`	`+ if (finallyHandler == null)`
	`675`	`+ base.CallFinallyHandler();`
`675`	`676`	`}`
`676`	`677`
`677`	`678`	`public new Task<TResult> Task`