Correcting TaskQueue race condition to capture success and exception

StanleyGoldman · Joen-UnLogick · StanleyGoldman · commit 05fd289ba861 · 2018-05-30T09:14:12.000-04:00
Co-Authored-By: @Joen-UnLogick <joengit@glscene.com>
diff --git a/src/GitHub.Api/Tasks/ActionTask.cs b/src/GitHub.Api/Tasks/ActionTask.cs
@@ -34,10 +34,12 @@ protected override void Run()
 
         private void TaskFinished(ITask task, bool success, Exception ex)
         {
-            var count = Interlocked.Increment(ref finishedTaskCount);
-            isSuccessful &= success;
             if (!success)
+            {
+                isSuccessful = false;
                 exception = ex;
+            }
+            var count = Interlocked.Increment(ref finishedTaskCount);
             if (count == queuedTasks.Count)
             {
                 if (isSuccessful)

Original file line number	Diff line number	Diff line change
`@@ -34,10 +34,12 @@ protected override void Run()`
`34`	`34`
`35`	`35`	`private void TaskFinished(ITask task, bool success, Exception ex)`
`36`	`36`	`{`
`37`		`- var count = Interlocked.Increment(ref finishedTaskCount);`
`38`		`- isSuccessful &= success;`
`39`	`37`	`if (!success)`
	`38`	`+ {`
	`39`	`+ isSuccessful = false;`
`40`	`40`	`exception = ex;`
	`41`	`+ }`
	`42`	`+ var count = Interlocked.Increment(ref finishedTaskCount);`
`41`	`43`	`if (count == queuedTasks.Count)`
`42`	`44`	`{`
`43`	`45`	`if (isSuccessful)`