Removing download result object

Author: StanleyGoldman

src/GitHub.Api/Tasks/DownloadTask.cs

@@ -75,17 +75,6 @@ public static bool Copy(Stream source, Stream destination, int chunkSize, long t
         }
     }
 
-    public class DownloadResult
-    {
-        public bool Success { get; set; }
-
-        public string Url { get; set; }
-
-        public string Destination { get; set; }
-
-        public string MD5Sum { get; set; }
-    }
-
     public static class WebRequestExtensions
     {
         public static WebResponse GetResponseWithoutException(this WebRequest request)
@@ -101,7 +90,7 @@ public static WebResponse GetResponseWithoutException(this WebRequest request)
         }
     }
 
-    class DownloadTask : TaskBase<DownloadResult>
+    class DownloadTask : TaskBase
     {
         private IFileSystem fileSystem;
         private long bytes;
@@ -119,9 +108,9 @@ public DownloadTask(CancellationToken token, IFileSystem fileSystem, string url,
             Name = "DownloadTask";
         }
 
-        protected override DownloadResult RunWithReturn(bool success)
+        protected override void Run(bool success)
         {
-            base.RunWithReturn(success);
+            base.Run(success);
 
             RaiseOnStart();
 
@@ -144,10 +133,8 @@ protected override DownloadResult RunWithReturn(bool success)
             }
             finally
             {
-                RaiseOnEnd(downloadResult);
+                RaiseOnEnd();
             }
-
-            return downloadResult;
         }
 
         protected virtual void UpdateProgress(float progress)

src/tests/IntegrationTests/Download/DownloadTaskTests.cs

@@ -26,12 +26,13 @@ public async Task TestDownloadTask()
             var downloadHalfPath = TestBasePath.Combine("5MB-split.zip");
 
             var downloadTask = new DownloadTask(CancellationToken.None, fileSystem, TestDownload, downloadPath);
-            var downloadResult = await downloadTask.StartAwait();
+            await downloadTask.StartAwait();
 
             var downloadPathBytes = fileSystem.ReadAllBytes(downloadPath);
             Logger.Trace("File size {0} bytes", downloadPathBytes.Length);
 
-            downloadResult.MD5Sum.Should().Be(TestDownloadMD5.ToUpperInvariant());
+            var md5Sum = fileSystem.CalculateMD5(downloadPath);
+            md5Sum.Should().Be(TestDownloadMD5.ToUpperInvariant());
 
             var random = new Random();
             var takeCount = random.Next(downloadPathBytes.Length);
@@ -42,12 +43,13 @@ public async Task TestDownloadTask()
             fileSystem.WriteAllBytes(downloadHalfPath, cutDownloadPathBytes);
 
             downloadTask = new DownloadTask(CancellationToken.None, fileSystem, TestDownload, downloadHalfPath);
-            downloadResult = await downloadTask.StartAwait();
+            await downloadTask.StartAwait();
 
             var downloadHalfPathBytes = fileSystem.ReadAllBytes(downloadHalfPath);
             Logger.Trace("File size {0} Bytes", downloadHalfPathBytes.Length);
 
-            downloadResult.MD5Sum.Should().Be(TestDownloadMD5.ToUpperInvariant());
+            md5Sum = fileSystem.CalculateMD5(downloadPath);
+            md5Sum.Should().Be(TestDownloadMD5.ToUpperInvariant());
         }
 
         [Test]