Using string for the interface instead of NPath

Author: StanleyGoldman

src/GitHub.Api/Git/GitClient.cs

@@ -10,7 +10,7 @@ interface IGitClient
     {
         Task<NPath> FindGitInstallation();
 
-        ITask<bool> ValidateGitInstall(NPath path);
+        ITask<bool> ValidateGitInstall(string path);
 
         ITask Init(IOutputProcessor<string> processor = null);
 
@@ -153,9 +153,9 @@ private async Task<NPath> LookForSystemGit()
             return path;
         }
 
-        public ITask<bool> ValidateGitInstall(NPath path)
+        public ITask<bool> ValidateGitInstall(string path)
         {
-            if (!path.FileExists())
+            if (!path.ToNPath().FileExists())
             {
                 return new FuncTask<bool>(cancellationToken, () => false);
             }
@@ -164,29 +164,23 @@ public ITask<bool> ValidateGitInstall(NPath path)
             SoftwareVersion? gitLfsVersion = null;
 
             var gitVersionTask = new GitVersionTask(cancellationToken);
-            gitVersionTask.Configure(processManager, path.ToString(), 
+            gitVersionTask.Configure(processManager, path, 
                 gitVersionTask.ProcessArguments, environment.RepositoryPath);
 
             var gitLfsVersionTask = new GitLfsVersionTask(cancellationToken);
-            gitLfsVersionTask.Configure(processManager, path.ToString(),
+            gitLfsVersionTask.Configure(processManager, path,
                 gitLfsVersionTask.ProcessArguments, environment.RepositoryPath);
 
             return gitVersionTask
                 .Then((result, version) => { gitVersion = version; })
                 .Then(gitLfsVersionTask)
                 .Then((result, version) => {
                     gitLfsVersion = version;
-                }).Then(result => {
-                    if (result)
-                    {
-                        return gitVersion.HasValue &&
-                            gitVersion.Value >= new SoftwareVersion(2, 1, 0) &&
-                            gitLfsVersion.HasValue &&
-                            gitLfsVersion.Value >= new SoftwareVersion(2, 1, 0);
-                    }
-
-                    return false;
-                });
+                }).Then(result => result &&
+                    gitVersion.HasValue &&
+                    gitVersion.Value >= new SoftwareVersion(2, 1, 0) &&
+                    gitLfsVersion.HasValue &&
+                    gitLfsVersion.Value >= new SoftwareVersion(2, 1, 0));
         }
 
         public ITask Init(IOutputProcessor<string> processor = null)