These are useful messages to mark as errors

shana · shana · commit 15251282552d · 2018-03-08T21:23:49.000+01:00
diff --git a/src/GitHub.Api/Tasks/TaskManager.cs b/src/GitHub.Api/Tasks/TaskManager.cs
@@ -85,7 +85,7 @@ private T ScheduleUI<T>(T task, bool setupFaultHandler)
             {
                 task.Task.ContinueWith(tt =>
                 {
-                    logger.Trace(tt.Exception.InnerException, String.Format("Exception on ui thread: {0} {1}", tt.Id, task.Name));
+                    logger.Error(tt.Exception.InnerException, String.Format("Exception on ui thread: {0} {1}", tt.Id, task.Name));
                 },
                     cts.Token,
                     TaskContinuationOptions.OnlyOnFaulted, ConcurrentScheduler
@@ -101,7 +101,7 @@ private T ScheduleExclusive<T>(T task, bool setupFaultHandler)
             {
                 task.Task.ContinueWith(tt =>
                 {
-                    logger.Trace(tt.Exception.InnerException, String.Format("Exception on exclusive thread: {0} {1}", tt.Id, task.Name));
+                    logger.Error(tt.Exception.InnerException, String.Format("Exception on exclusive thread: {0} {1}", tt.Id, task.Name));
                 },
                     cts.Token,
                     TaskContinuationOptions.OnlyOnFaulted, ConcurrentScheduler
@@ -117,7 +117,7 @@ private T ScheduleConcurrent<T>(T task, bool setupFaultHandler)
             {
                 task.Task.ContinueWith(tt =>
                 {
-                    logger.Trace(tt.Exception.InnerException, String.Format("Exception on concurrent thread: {0} {1}", tt.Id, task.Name));
+                    logger.Error(tt.Exception.InnerException, String.Format("Exception on concurrent thread: {0} {1}", tt.Id, task.Name));
                 },
                     cts.Token,
                     TaskContinuationOptions.OnlyOnFaulted, ConcurrentScheduler

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ private T ScheduleUI<T>(T task, bool setupFaultHandler)`
`85`	`85`	`{`
`86`	`86`	`task.Task.ContinueWith(tt =>`
`87`	`87`	`{`
`88`		`- logger.Trace(tt.Exception.InnerException, String.Format("Exception on ui thread: {0} {1}", tt.Id, task.Name));`
	`88`	`+ logger.Error(tt.Exception.InnerException, String.Format("Exception on ui thread: {0} {1}", tt.Id, task.Name));`
`89`	`89`	`},`
`90`	`90`	`cts.Token,`
`91`	`91`	`TaskContinuationOptions.OnlyOnFaulted, ConcurrentScheduler`
`@@ -101,7 +101,7 @@ private T ScheduleExclusive<T>(T task, bool setupFaultHandler)`
`101`	`101`	`{`
`102`	`102`	`task.Task.ContinueWith(tt =>`
`103`	`103`	`{`
`104`		`- logger.Trace(tt.Exception.InnerException, String.Format("Exception on exclusive thread: {0} {1}", tt.Id, task.Name));`
	`104`	`+ logger.Error(tt.Exception.InnerException, String.Format("Exception on exclusive thread: {0} {1}", tt.Id, task.Name));`
`105`	`105`	`},`
`106`	`106`	`cts.Token,`
`107`	`107`	`TaskContinuationOptions.OnlyOnFaulted, ConcurrentScheduler`
`@@ -117,7 +117,7 @@ private T ScheduleConcurrent<T>(T task, bool setupFaultHandler)`
`117`	`117`	`{`
`118`	`118`	`task.Task.ContinueWith(tt =>`
`119`	`119`	`{`
`120`		`- logger.Trace(tt.Exception.InnerException, String.Format("Exception on concurrent thread: {0} {1}", tt.Id, task.Name));`
	`120`	`+ logger.Error(tt.Exception.InnerException, String.Format("Exception on concurrent thread: {0} {1}", tt.Id, task.Name));`
`121`	`121`	`},`
`122`	`122`	`cts.Token,`
`123`	`123`	`TaskContinuationOptions.OnlyOnFaulted, ConcurrentScheduler`