Make sure we always delete temp directories

Author: shana

src/GitHub.Api/Installer/OctorunInstaller.cs

@@ -44,6 +44,7 @@ public NPath SetupOctorunIfNeeded()
                 var extractPath = unzipTask.RunWithReturn(true);
                 if (unzipTask.Successful)
                     path = MoveOctorun(extractPath.Combine("octorun"));
+                tempZipExtractPath.DeleteIfExists();
             }
             return path;
         }

src/GitHub.Api/Tasks/DownloadTask.cs

@@ -32,15 +32,15 @@ class DownloadTask : TaskBase<NPath>
         public DownloadTask(CancellationToken token,
             IFileSystem fileSystem,
             UriString url,
-            NPath? targetDirectory = null,
+            NPath targetDirectory,
             int retryCount = 0)
             : base(token)
         {
             this.fileSystem = fileSystem;
             RetryCount = retryCount;
             Url = url;
             Filename = url.Filename;
-            TargetDirectory = targetDirectory ?? NPath.CreateTempDirectory("ghu");
+            TargetDirectory = targetDirectory;
             this.Name = $"Download {Url}";
         }
 

src/tests/IntegrationTests/Download/DownloadTaskTests.cs

@@ -318,7 +318,7 @@ public void DownloadingFromNonExistingDomainThrows()
 
             var fileSystem = NPath.FileSystem;
 
-            var downloadTask = new DownloadTask(TaskManager.Token, fileSystem, "http://ggggithub.com/robots.txt");
+            var downloadTask = new DownloadTask(TaskManager.Token, fileSystem, "http://ggggithub.com/robots.txt", TestBasePath);
             var exceptionThrown = false;
 
             var autoResetEvent = new AutoResetEvent(false);