Merge branch 'fixes/long-publish-error-message' into fixes/api-failure-switch-auth-view

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PublishView.cs

@@ -21,6 +21,7 @@ class PublishView : Subview
         private const string RepositoryNameLabel = "Repository Name";
         private const string DescriptionLabel = "Description";
         private const string CreatePrivateRepositoryLabel = "Create as a private repository";
+        private const string PublishLimtPrivateRepositoriesError = "You are currently at your limt of private repositories";
         private const string AuthenticationChangedMessageFormat = "You were authenticated as \"{0}\", but you are now authenticated as \"{1}\". Would you like to proceed or logout?";
         private const string AuthenticationChangedTitle = "Authentication Changed";
         private const string AuthenticationChangedProceed = "Proceed";
@@ -252,11 +253,11 @@ public override void OnGUI()
                             Description = cleanRepoDescription
                         }, (repository, ex) =>
                         {
-                            Logger.Trace("Create Repository Callback");
-
                             if (ex != null)
                             {
-                                error = ex.Message;
+                                Logger.Error(ex, "Repository Create Error Type:{0}", ex.GetType().ToString());
+
+                                error = GetPublishErrorMessage(ex);
                                 isBusy = false;
                                 return;
                             }
@@ -268,6 +269,8 @@ public override void OnGUI()
                                 return;
                             }
 
+                            Logger.Trace("Repository Created");
+
                             GitClient.RemoteAdd("origin", repository.CloneUrl)
                                      .Then(GitClient.Push("origin", Repository.CurrentBranch.Value.Name))
                                      .ThenInUI(Finish)
@@ -282,6 +285,16 @@ public override void OnGUI()
             EditorGUI.EndDisabledGroup();
         }
 
+        private string GetPublishErrorMessage(Exception ex)
+        {
+            if (ex.Message.StartsWith(PublishLimtPrivateRepositoriesError))
+            {
+                return PublishLimtPrivateRepositoriesError;
+            }
+
+            return ex.Message;
+        }
+
         public override bool IsBusy
         {
             get { return isBusy; }