Merge pull request #828 from github-for-unity/fixes/reduce-auth-scope

Reducing the authentication scope requested by GitHub for Unity

Author: StanleyGoldman

docs/using/authenticating-to-github.md

@@ -30,6 +30,8 @@ The scopes for the personal access token are: `user`, `repo`.
 - *user* scope: Grants access to the user profile data. We currently use this to display your avatar and check whether your plans lets you publish private repositories.
 - *repo* scope: Grants read/write access to code, commit statuses, invitations, collaborators, adding team memberships, and deployment statuses for public and private repositories and organizations. This is needed for all git network operations (push, pull, fetch), and for getting information about the repository you're currently working on.
 
+<sub>***Note:*** *Some older versions of the plugin ask for `gist` and `write:public_key`.*</sub>
+
 For more information on creating personal access tokens, see "[Creating a personal access token for the command line](https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line).
 
 For more information on authenticating with SAML single sign-on, see "[About authentication with SAML single sign-on](https://help.github.com/articles/about-authentication-with-saml-single-sign-on)."

octorun/src/authentication.js

@@ -4,7 +4,7 @@ var octokitWrapper = require("./octokit");
 
 var twoFactorRegex = new RegExp("must specify two-factor authentication otp code", "gi");
 
-var scopes = ["user", "repo", "gist", "write:public_key"];
+var scopes = ["user", "repo"];
 
 var handleAuthentication = function (username, password, onSuccess, onFailure, twoFactor) {
     if (!config.clientId || !config.clientSecret) {

octorun/version

@@ -1 +1 @@
-b4b80eb4ac
+7f160da1

src/GitHub.Api/Installer/OctorunInstaller.cs

@@ -85,7 +85,7 @@ public class OctorunInstallDetails
             public const string DefaultZipMd5Url = "http://github-vs.s3.amazonaws.com/unity/octorun/octorun.zip.md5";
             public const string DefaultZipUrl = "http://github-vs.s3.amazonaws.com/unity/octorun/octorun.zip";
 
-            public const string PackageVersion = "b4b80eb4ac";
+            public const string PackageVersion = "7f160da1";
             private const string PackageName = "octorun";
             private const string zipFile = "octorun.zip";
 

src/GitHub.Api/Resources/octorun.zip

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:802c9a15337ce6692f8c4c215a131b755358972cb3a7e76139193855770ab1c8
-size 214371
+oid sha256:60478c33970a7a8d952777729450a42fa02bf7832514b7d44ec116aa09cb7814
+size 219592

src/GitHub.Api/Resources/octorun.zip.md5

@@ -1 +1 @@
-0a49f36d2e8df01456f832c6968a6782
+3d4bea9ae4ca3c4497d6b349166a1e34