Merge branch 'master' into enhancements/git-lfs-230

StanleyGoldman · web-flow · commit 2350c3e1a5e3 · 2017-09-19T13:33:47.000-04:00
diff --git a/script b/script
@@ -1 +1 @@
-Subproject commit 8aa682c1a7e9e60fab2c239503e1e0553b1e7714
+Subproject commit 591ff936add8cc2e165712b523a8597a66233478
diff --git a/src/GitHub.Api/Application/IApplicationManager.cs b/src/GitHub.Api/Application/IApplicationManager.cs
@@ -4,7 +4,7 @@
 
 namespace GitHub.Unity
 {
-    interface IApplicationManager : IDisposable
+    public interface IApplicationManager : IDisposable
     {
         CancellationToken CancellationToken { get; }
         IEnvironment Environment { get; }
diff --git a/src/GitHub.Api/Authentication/ICredentialManager.cs b/src/GitHub.Api/Authentication/ICredentialManager.cs
@@ -3,15 +3,15 @@
 
 namespace GitHub.Unity
 {
-    interface ICredential : IDisposable
+    public interface ICredential : IDisposable
     {
         UriString Host { get; }
         string Username { get; }
         string Token { get; }
         void UpdateToken(string token);
     }
 
-    interface ICredentialManager
+    public interface ICredentialManager
     {
         Task<ICredential> Load(UriString host);
         Task Save(ICredential cred);
diff --git a/src/GitHub.Api/Authentication/IKeychain.cs b/src/GitHub.Api/Authentication/IKeychain.cs
@@ -3,7 +3,7 @@
 
 namespace GitHub.Unity
 {
-    interface IKeychain
+    public interface IKeychain
     {
         IKeychainAdapter Connect(UriString host);
         Task<IKeychainAdapter> Load(UriString host);
diff --git a/src/GitHub.Api/Authentication/Keychain.cs b/src/GitHub.Api/Authentication/Keychain.cs
@@ -6,7 +6,7 @@
 
 namespace GitHub.Unity
 {
-    struct Connection
+    public struct Connection
     {
         public UriString Host;
         public string Username;
diff --git a/src/GitHub.Api/Authentication/KeychainAdapter.cs b/src/GitHub.Api/Authentication/KeychainAdapter.cs
@@ -36,7 +36,7 @@ Task<Credentials> ICredentialStore.GetCredentials()
         }
     }
 
-    interface IKeychainAdapter: ICredentialStore
+    public interface IKeychainAdapter: ICredentialStore
     {
         Credentials OctokitCredentials { get; }
         ICredential Credential { get; }
diff --git a/src/GitHub.Api/Git/GitBranch.cs b/src/GitHub.Api/Git/GitBranch.cs
@@ -9,7 +9,7 @@ interface ITreeData
     }
 
     [Serializable]
-    struct GitBranch : ITreeData
+    public struct GitBranch : ITreeData
     {
         private string name;
         private string tracking;
diff --git a/src/GitHub.Api/Git/GitClient.cs b/src/GitHub.Api/Git/GitClient.cs
@@ -6,7 +6,7 @@
 
 namespace GitHub.Unity
 {
-    interface IGitClient
+    public interface IGitClient
     {
         Task<NPath> FindGitInstallation();
         ITask<ValidateGitInstallResult> ValidateGitInstall(NPath path);
diff --git a/src/GitHub.Api/Git/GitConfig.cs b/src/GitHub.Api/Git/GitConfig.cs
@@ -31,7 +31,7 @@ public override string ToString()
         }
     }
 
-    interface IGitConfig
+    public interface IGitConfig
     {
         void Reset();
         IEnumerable<ConfigBranch> GetBranches();
diff --git a/src/GitHub.Api/Git/GitConfigSource.cs b/src/GitHub.Api/Git/GitConfigSource.cs
@@ -1,6 +1,6 @@
 namespace GitHub.Unity
 {
-    enum GitConfigSource
+    public enum GitConfigSource
     {
         NonSpecified,
         Local,
diff --git a/src/GitHub.Api/Git/GitFileStatus.cs b/src/GitHub.Api/Git/GitFileStatus.cs
@@ -1,6 +1,6 @@
 namespace GitHub.Unity
 {
-    enum GitFileStatus
+    public enum GitFileStatus
     {
         None,
         Untracked,
diff --git a/src/GitHub.Api/Git/GitLock.cs b/src/GitHub.Api/Git/GitLock.cs
@@ -3,7 +3,7 @@
 namespace GitHub.Unity
 {
     [Serializable]
-    struct GitLock
+    public struct GitLock
     {
         public static GitLock Default = new GitLock(null, null, null, -1);
 
diff --git a/src/GitHub.Api/Git/GitLogEntry.cs b/src/GitHub.Api/Git/GitLogEntry.cs
@@ -6,7 +6,7 @@
 namespace GitHub.Unity
 {
     [Serializable]
-    struct GitLogEntry
+    public struct GitLogEntry
     {
         private const string Today = "Today";
         private const string Yesterday = "Yesterday";
diff --git a/src/GitHub.Api/Git/GitStatus.cs b/src/GitHub.Api/Git/GitStatus.cs
@@ -4,7 +4,7 @@
 namespace GitHub.Unity
 {
     [Serializable]
-    struct GitStatus
+    public struct GitStatus
     {
         public string LocalBranch;
         public string RemoteBranch;
diff --git a/src/GitHub.Api/Git/GitStatusEntry.cs b/src/GitHub.Api/Git/GitStatusEntry.cs
@@ -3,7 +3,7 @@
 namespace GitHub.Unity
 {
     [Serializable]
-    struct GitStatusEntry
+    public struct GitStatusEntry
     {
         public string Path;
         public string FullPath;
diff --git a/src/GitHub.Api/Git/IRepository.cs b/src/GitHub.Api/Git/IRepository.cs
@@ -6,7 +6,7 @@ namespace GitHub.Unity
     /// <summary>
     /// Represents a repository, either local or retreived via the GitHub API.
     /// </summary>
-    interface IRepository : IEquatable<IRepository>
+    public interface IRepository : IEquatable<IRepository>
     {
         void Initialize(IRepositoryManager repositoryManager);
         void Refresh();
diff --git a/src/GitHub.Api/Git/Repository.cs b/src/GitHub.Api/Git/Repository.cs
@@ -280,7 +280,7 @@ public GitStatus CurrentStatus
         protected static ILogging Logger { get; } = Logging.GetLogger<Repository>();
     }
 
-    interface IUser
+    public interface IUser
     {
         string Name { get; set; }
         string Email { get; set; }
diff --git a/src/GitHub.Api/Git/RepositoryManager.cs b/src/GitHub.Api/Git/RepositoryManager.cs
@@ -6,7 +6,7 @@
 
 namespace GitHub.Unity
 {
-    interface IRepositoryManager : IDisposable
+    public interface IRepositoryManager : IDisposable
     {
         event Action<bool> OnIsBusyChanged;
 
diff --git a/src/GitHub.Api/Git/ValidateGitInstallResult.cs b/src/GitHub.Api/Git/ValidateGitInstallResult.cs
@@ -2,7 +2,7 @@
 
 namespace GitHub.Unity
 {
-    struct ValidateGitInstallResult
+    public struct ValidateGitInstallResult
     {
         public bool IsValid;
         public Version GitVersion;
diff --git a/src/GitHub.Api/IO/IFileSystem.cs b/src/GitHub.Api/IO/IFileSystem.cs
@@ -4,7 +4,7 @@
 
 namespace GitHub.Unity
 {
-    interface IFileSystem
+    public interface IFileSystem
     {
         bool FileExists(string path);
         string Combine(string path1, string path2);
diff --git a/src/GitHub.Api/IO/NiceIO.cs b/src/GitHub.Api/IO/NiceIO.cs
@@ -40,7 +40,7 @@
 #if NICEIO
     public
 #endif
-    class NPath : IEquatable<NPath>, IComparable
+    public class NPath : IEquatable<NPath>, IComparable
     {
         private static StringComparison? pathStringComparison;
         private static StringComparison PathStringComparison
diff --git a/src/GitHub.Api/Metrics/UsageModel.cs b/src/GitHub.Api/Metrics/UsageModel.cs
@@ -4,7 +4,7 @@
 
 namespace GitHub.Unity
 {
-    class Usage
+    public class Usage
     {
         public string Guid { get; set; }
         public DateTime Date { get; set; }
diff --git a/src/GitHub.Api/NewTaskSystem/BaseOutputProcessor.cs b/src/GitHub.Api/NewTaskSystem/BaseOutputProcessor.cs
@@ -4,23 +4,23 @@
 
 namespace GitHub.Unity
 {
-    interface IOutputProcessor
+    public interface IOutputProcessor
     {
         void LineReceived(string line);
     }
 
-    interface IOutputProcessor<T> : IOutputProcessor
+    public interface IOutputProcessor<T> : IOutputProcessor
     {
         T Result { get; }
         event Action<T> OnEntry;
     }
 
-    interface IOutputProcessor<TData, T> : IOutputProcessor<T>
+    public interface IOutputProcessor<TData, T> : IOutputProcessor<T>
     {
         new event Action<TData> OnEntry;
     }
 
-    abstract class BaseOutputProcessor<T> : IOutputProcessor<T>
+    public abstract class BaseOutputProcessor<T> : IOutputProcessor<T>
     {
         public event Action<T> OnEntry;
 
@@ -36,7 +36,7 @@ protected void RaiseOnEntry(T entry)
         protected ILogging Logger { get { return logger = logger ?? Logging.GetLogger(GetType()); } }
     }
 
-    abstract class BaseOutputProcessor<TData, T> : BaseOutputProcessor<T>, IOutputProcessor<TData, T>
+    public abstract class BaseOutputProcessor<TData, T> : BaseOutputProcessor<T>, IOutputProcessor<TData, T>
     {
         public new event Action<TData> OnEntry;
 
@@ -46,7 +46,7 @@ protected virtual void RaiseOnEntry(TData entry)
         }
     }
 
-    abstract class BaseOutputListProcessor<T> : BaseOutputProcessor<T, List<T>>
+    public abstract class BaseOutputListProcessor<T> : BaseOutputProcessor<T, List<T>>
     {
         protected override void RaiseOnEntry(T entry)
         {
diff --git a/src/GitHub.Api/NewTaskSystem/ITaskManager.cs b/src/GitHub.Api/NewTaskSystem/ITaskManager.cs
@@ -4,7 +4,7 @@
 
 namespace GitHub.Unity
 {
-    interface ITaskManager : IDisposable
+    public interface ITaskManager : IDisposable
     {
         TaskScheduler ConcurrentScheduler { get; }
         TaskScheduler ExclusiveScheduler { get; }
diff --git a/src/GitHub.Api/NewTaskSystem/ProcessTask.cs b/src/GitHub.Api/NewTaskSystem/ProcessTask.cs
@@ -27,7 +27,7 @@ public static T Configure<T>(this T task, IProcessManager processManager, string
         }
     }
 
-    interface IProcess
+    public interface IProcess
     {
         void Configure(Process existingProcess);
         void Configure(ProcessStartInfo psi);
@@ -288,8 +288,8 @@ protected override T RunWithReturn(bool success)
                     if (outputProcessor != null)
                         result = outputProcessor.Result;
 
-                    if (result == null && typeof(T) == typeof(string))
-                        result = (T)(object)(Process.StartInfo.CreateNoWindow ? "Process finished" : "Process running");
+                    if (result == null && !Process.StartInfo.CreateNoWindow && typeof(T) == typeof(string))
+                        result = (T)(object)"Process running";
 
                     RaiseOnEnd(result);
 
diff --git a/src/GitHub.Api/NewTaskSystem/TaskBase.cs b/src/GitHub.Api/NewTaskSystem/TaskBase.cs
@@ -4,7 +4,7 @@
 
 namespace GitHub.Unity
 {
-    interface ITask : IAsyncResult
+    public interface ITask : IAsyncResult
     {
         T Then<T>(T continuation, bool always = false) where T : ITask;
         ITask Catch(Action<Exception> handler);
@@ -28,7 +28,7 @@ interface ITask : IAsyncResult
         event Action<ITask> OnEnd;
     }
 
-    interface ITask<TResult> : ITask
+    public interface ITask<TResult> : ITask
     {
         new ITask<TResult> Catch(Action<Exception> handler);
         new ITask<TResult> Catch(Func<Exception, bool> handler);
@@ -51,7 +51,7 @@ interface ITask<TData, T> : ITask<T>
 
     interface IStubTask { }
 
-    abstract class TaskBase : ITask
+    public abstract class TaskBase : ITask
     {
         protected const TaskContinuationOptions runAlwaysOptions = TaskContinuationOptions.None;
         protected const TaskContinuationOptions runOnSuccessOptions = TaskContinuationOptions.OnlyOnRanToCompletion;
@@ -677,7 +677,7 @@ public static T ScheduleConcurrent<T>(this T task, ITaskManager taskManager)
         }
     }
 
-    enum TaskAffinity
+    public enum TaskAffinity
     {
         Concurrent,
         Exclusive,
diff --git a/src/GitHub.Api/OutputProcessors/IProcessManager.cs b/src/GitHub.Api/OutputProcessors/IProcessManager.cs
@@ -2,7 +2,7 @@
 
 namespace GitHub.Unity
 {
-    interface IProcessManager
+    public interface IProcessManager
     {
         T Configure<T>(T processTask, NPath executable = null, string arguments = null, NPath workingDirectory = null, bool withInput = false)
             where T : IProcess;
diff --git a/src/GitHub.Api/Platform/DefaultEnvironment.cs b/src/GitHub.Api/Platform/DefaultEnvironment.cs
@@ -4,7 +4,7 @@
 
 namespace GitHub.Unity
 {
-    class DefaultEnvironment : IEnvironment
+    public class DefaultEnvironment : IEnvironment
     {
         private const string logFile = "github-unity.log";
 
diff --git a/src/GitHub.Api/Platform/IEnvironment.cs b/src/GitHub.Api/Platform/IEnvironment.cs
@@ -2,7 +2,7 @@
 
 namespace GitHub.Unity
 {
-    interface IEnvironment
+    public interface IEnvironment
     {
         void Initialize(string unityVersion, NPath extensionInstallPath, NPath unityPath, NPath assetsPath);
         void InitializeRepository(NPath expectedRepositoryPath = null);
diff --git a/src/GitHub.Api/Platform/IProcessEnvironment.cs b/src/GitHub.Api/Platform/IProcessEnvironment.cs
@@ -2,7 +2,7 @@
 
 namespace GitHub.Unity
 {
-    interface IProcessEnvironment
+    public interface IProcessEnvironment
     {
         void Configure(ProcessStartInfo psi, NPath workingDirectory);
 
diff --git a/src/GitHub.Api/Platform/ISettings.cs b/src/GitHub.Api/Platform/ISettings.cs
@@ -1,6 +1,6 @@
 namespace GitHub.Unity
 {
-    interface ISettings
+    public interface ISettings
     {
         void Initialize();
         bool Exists(string key);
diff --git a/src/GitHub.Api/Platform/Platform.cs b/src/GitHub.Api/Platform/Platform.cs
@@ -2,7 +2,7 @@
 
 namespace GitHub.Unity
 {
-    interface IPlatform
+    public interface IPlatform
     {
         IPlatform Initialize(IProcessManager processManager, ITaskManager taskManager);
         IProcessEnvironment GitEnvironment { get; }
diff --git a/src/GitHub.Logging/LogAdapterBase.cs b/src/GitHub.Logging/LogAdapterBase.cs
@@ -1,6 +1,6 @@
 namespace GitHub.Unity
 {
-    abstract class LogAdapterBase
+    public abstract class LogAdapterBase
     {
         public abstract void Info(string context, string message);
 
diff --git a/src/GitHub.Logging/Logging.cs b/src/GitHub.Logging/Logging.cs
@@ -25,7 +25,7 @@ public override void Error(string context, string message)
         }
     }
 
-    static class Logging
+    public static class Logging
     {
         private static readonly LogAdapterBase nullLogAdapter = new NullLogAdapter();
 
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/EntryPoint.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/EntryPoint.cs
@@ -9,7 +9,7 @@
 namespace GitHub.Unity
 {
     [InitializeOnLoad]
-    class EntryPoint : ScriptableObject
+    public class EntryPoint : ScriptableObject
     {
         // this may run on the loader thread if it's an appdomain restart
         static EntryPoint()
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj b/src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj
@@ -102,6 +102,7 @@
     <Compile Include="UI\IView.cs" />
     <Compile Include="UI\LoadingView.cs" />
     <Compile Include="UI\PublishView.cs" />
+    <Compile Include="UI\UserSettingsView.cs" />
     <Compile Include="UI\GitPathView.cs" />
     <Compile Include="UI\SettingsView.cs" />
     <Compile Include="UI\Subview.cs" />
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cs
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cs.meta b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cs.meta
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/UserSettingsView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/UserSettingsView.cs
diff --git a/src/tests/IntegrationTests/Process/ProcessManagerIntegrationTests.cs b/src/tests/IntegrationTests/Process/ProcessManagerIntegrationTests.cs

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`namespace GitHub.Unity`
`6`	`6`	`{`
`7`		`- interface IApplicationManager : IDisposable`
	`7`	`+ public interface IApplicationManager : IDisposable`
`8`	`8`	`{`
`9`	`9`	`CancellationToken CancellationToken { get; }`
`10`	`10`	`IEnvironment Environment { get; }`
Original file line number	Diff line number	Diff line change
`@@ -3,15 +3,15 @@`
`3`	`3`
`4`	`4`	`namespace GitHub.Unity`
`5`	`5`	`{`
`6`		`- interface ICredential : IDisposable`
	`6`	`+ public interface ICredential : IDisposable`
`7`	`7`	`{`
`8`	`8`	`UriString Host { get; }`
`9`	`9`	`string Username { get; }`
`10`	`10`	`string Token { get; }`
`11`	`11`	`void UpdateToken(string token);`
`12`	`12`	`}`
`13`	`13`
`14`		`- interface ICredentialManager`
	`14`	`+ public interface ICredentialManager`
`15`	`15`	`{`
`16`	`16`	`Task<ICredential> Load(UriString host);`
`17`	`17`	`Task Save(ICredential cred);`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`namespace GitHub.Unity`
`5`	`5`	`{`
`6`		`- interface IKeychain`
	`6`	`+ public interface IKeychain`
`7`	`7`	`{`
`8`	`8`	`IKeychainAdapter Connect(UriString host);`
`9`	`9`	`Task<IKeychainAdapter> Load(UriString host);`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`namespace GitHub.Unity`
`8`	`8`	`{`
`9`		`- struct Connection`
	`9`	`+ public struct Connection`
`10`	`10`	`{`
`11`	`11`	`public UriString Host;`
`12`	`12`	`public string Username;`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ Task<Credentials> ICredentialStore.GetCredentials()`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
`39`		`- interface IKeychainAdapter: ICredentialStore`
	`39`	`+ public interface IKeychainAdapter: ICredentialStore`
`40`	`40`	`{`
`41`	`41`	`Credentials OctokitCredentials { get; }`
`42`	`42`	`ICredential Credential { get; }`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ interface ITreeData`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`[Serializable]`
`12`		`- struct GitBranch : ITreeData`
	`12`	`+ public struct GitBranch : ITreeData`
`13`	`13`	`{`
`14`	`14`	`private string name;`
`15`	`15`	`private string tracking;`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`namespace GitHub.Unity`
`8`	`8`	`{`
`9`		`- interface IGitClient`
	`9`	`+ public interface IGitClient`
`10`	`10`	`{`
`11`	`11`	`Task<NPath> FindGitInstallation();`
`12`	`12`	`ITask<ValidateGitInstallResult> ValidateGitInstall(NPath path);`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public override string ToString()`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`
`34`		`- interface IGitConfig`
	`34`	`+ public interface IGitConfig`
`35`	`35`	`{`
`36`	`36`	`void Reset();`
`37`	`37`	`IEnumerable<ConfigBranch> GetBranches();`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`namespace GitHub.Unity`
`2`	`2`	`{`
`3`		`- enum GitConfigSource`
	`3`	`+ public enum GitConfigSource`
`4`	`4`	`{`
`5`	`5`	`NonSpecified,`
`6`	`6`	`Local,`