Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 23b4587

Browse files
shanashana
authored
Merge pull request #165 from github-for-unity/enhancements/codeanalysis
Fixing Code Analysis settings
2 parents d57f5d6 + 7d4c985 commit 23b4587

File tree

4 files changed

+104
-3
lines changed

4 files changed

+104
-3
lines changed

‎common/GitHub.ruleset renamed to ‎common/codeanalysis-full.ruleset

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<RuleSet Name="GitHub" Description="This ruleset only includes the rules we care about. I'll be adding new ones as we fix our codebase." ToolsVersion="14.0">
2+
<RuleSet Name="codeanalysis-full" Description="This ruleset only includes the rules we care about. I'll be adding new ones as we fix our codebase." ToolsVersion="14.0">
33
<IncludeAll Action="Warning" />
44
<Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
55
<Rule Id="CA1000" Action="None" />

‎common/codeanalysis-small.ruleset

Lines changed: 101 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,101 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<RuleSet Name="codeanalysis-small" Description="This ruleset only includes the rules we care about. I'll be adding new ones as we fix our codebase." ToolsVersion="14.0">
3+
<IncludeAll Action="Warning" />
4+
<Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
5+
<Rule Id="CA1000" Action="None" />
6+
<Rule Id="CA1002" Action="None" />
7+
<Rule Id="CA1006" Action="None" />
8+
<Rule Id="CA1014" Action="None" />
9+
<Rule Id="CA1017" Action="None" />
10+
<Rule Id="CA1020" Action="None" />
11+
<Rule Id="CA1021" Action="None" />
12+
<Rule Id="CA1024" Action="None" />
13+
<Rule Id="CA1026" Action="None" />
14+
<Rule Id="CA1030" Action="None" />
15+
<Rule Id="CA1031" Action="None" />
16+
<Rule Id="CA1033" Action="None" />
17+
<Rule Id="CA1034" Action="None" />
18+
<Rule Id="CA1045" Action="None" />
19+
<Rule Id="CA1051" Action="None" />
20+
<Rule Id="CA1054" Action="None" />
21+
<Rule Id="CA1055" Action="None" />
22+
<Rule Id="CA1056" Action="None" />
23+
<Rule Id="CA1062" Action="None" />
24+
<Rule Id="CA1063" Action="None" />
25+
<Rule Id="CA1303" Action="None" />
26+
<Rule Id="CA1305" Action="None" />
27+
<Rule Id="CA1307" Action="None" />
28+
<Rule Id="CA1401" Action="None" />
29+
<Rule Id="CA1402" Action="None" />
30+
<Rule Id="CA1403" Action="None" />
31+
<Rule Id="CA1405" Action="None" />
32+
<Rule Id="CA1406" Action="None" />
33+
<Rule Id="CA1407" Action="None" />
34+
<Rule Id="CA1408" Action="None" />
35+
<Rule Id="CA1409" Action="None" />
36+
<Rule Id="CA1410" Action="None" />
37+
<Rule Id="CA1411" Action="None" />
38+
<Rule Id="CA1412" Action="None" />
39+
<Rule Id="CA1413" Action="None" />
40+
<Rule Id="CA1501" Action="None" />
41+
<Rule Id="CA1502" Action="None" />
42+
<Rule Id="CA1506" Action="None" />
43+
<Rule Id="CA1701" Action="None" />
44+
<Rule Id="CA1702" Action="None" />
45+
<Rule Id="CA1703" Action="None" />
46+
<Rule Id="CA1704" Action="None" />
47+
<Rule Id="CA1707" Action="None" />
48+
<Rule Id="CA1708" Action="None" />
49+
<Rule Id="CA1709" Action="None" />
50+
<Rule Id="CA1710" Action="None" />
51+
<Rule Id="CA1711" Action="None" />
52+
<Rule Id="CA1712" Action="None" />
53+
<Rule Id="CA1713" Action="None" />
54+
<Rule Id="CA1714" Action="None" />
55+
<Rule Id="CA1715" Action="None" />
56+
<Rule Id="CA1716" Action="None" />
57+
<Rule Id="CA1717" Action="None" />
58+
<Rule Id="CA1719" Action="None" />
59+
<Rule Id="CA1720" Action="None" />
60+
<Rule Id="CA1721" Action="None" />
61+
<Rule Id="CA1722" Action="None" />
62+
<Rule Id="CA1724" Action="None" />
63+
<Rule Id="CA1725" Action="None" />
64+
<Rule Id="CA1726" Action="None" />
65+
<Rule Id="CA1800" Action="None" />
66+
<Rule Id="CA1801" Action="None" />
67+
<Rule Id="CA1810" Action="None" />
68+
<Rule Id="CA1811" Action="None" />
69+
<Rule Id="CA1812" Action="None" />
70+
<Rule Id="CA1822" Action="None" />
71+
<Rule Id="CA2000" Action="None" />
72+
<Rule Id="CA2118" Action="None" />
73+
<Rule Id="CA2122" Action="None" />
74+
<Rule Id="CA2200" Action="None" />
75+
<Rule Id="CA2201" Action="Warning" />
76+
<Rule Id="CA2204" Action="None" />
77+
<Rule Id="CA2210" Action="None" />
78+
<Rule Id="CA2211" Action="None" />
79+
<Rule Id="CA2213" Action="None" />
80+
<Rule Id="CA2227" Action="None" />
81+
<Rule Id="CA2235" Action="None" />
82+
<Rule Id="IDE001" Action="None" />
83+
84+
<!-- strings -->
85+
<Rule Id="CA1304" Action="None" />
86+
<Rule Id="CA1308" Action="None" />
87+
<Rule Id="CA1309" Action="None" />
88+
<Rule Id="CA1820" Action="None" />
89+
<Rule Id="CA1823" Action="None" />
90+
91+
<!-- serialization -->
92+
<Rule Id="CA2237" Action="None" />
93+
<Rule Id="CA1032" Action="None" />
94+
95+
<!-- link demand -->
96+
<Rule Id="CA2123" Action="None" />
97+
</Rules>
98+
<Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.Features" RuleNamespace="Microsoft.CodeAnalysis.CSharp.Features">
99+
<Rule Id="IDE0001" Action="None" />
100+
</Rules>
101+
</RuleSet>

‎src/GitHub.Api/GitHub.Api.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<ErrorReport>prompt</ErrorReport>
2828
<WarningLevel>4</WarningLevel>
2929
<RunCodeAnalysis>false</RunCodeAnalysis>
30-
<CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
30+
<CodeAnalysisRuleSet>..\..\common\codeanalysis-small.ruleset</CodeAnalysisRuleSet>
3131
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
3232
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3333
</PropertyGroup>

‎src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<ErrorReport>prompt</ErrorReport>
2424
<WarningLevel>4</WarningLevel>
2525
<RunCodeAnalysis>false</RunCodeAnalysis>
26-
<CodeAnalysisRuleSet>$(SolutionDir)common\GitHub.ruleset</CodeAnalysisRuleSet>
26+
<CodeAnalysisRuleSet>..\..\..\..\..\common\codeanalysis-small.ruleset</CodeAnalysisRuleSet>
2727
<LangVersion>4</LangVersion>
2828
</PropertyGroup>
2929
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">

0 commit comments

Comments
 (0)