Log task exceptions properly

shana · shana · commit 25c9a8c4af49 · 2017-05-08T15:44:22.000+02:00
diff --git a/src/GitHub.Api/Tasks/TaskRunnerBase.cs b/src/GitHub.Api/Tasks/TaskRunnerBase.cs
@@ -143,7 +143,7 @@ private void Start()
 
                     if (!repeat)
                     {
-                        Logger.Error(TaskThreadExceptionRestartError, e);
+                        Logger.Error(TaskThreadExceptionRestartError, e.InnerException ?? e);
                         Thread.Sleep(FailureDelayDefault);
                     }
                     else
@@ -219,7 +219,7 @@ private void RunLoop()
                         }
                         catch (Exception ex)
                         {
-                            Logger.Error(ex);
+                            Logger.Error(ex.InnerException ?? ex);
                             activeTask.RaiseOnEnd();
                             activeTask = null;
                         }

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ private void Start()`
`143`	`143`
`144`	`144`	`if (!repeat)`
`145`	`145`	`{`
`146`		`- Logger.Error(TaskThreadExceptionRestartError, e);`
	`146`	`+ Logger.Error(TaskThreadExceptionRestartError, e.InnerException ?? e);`
`147`	`147`	`Thread.Sleep(FailureDelayDefault);`
`148`	`148`	`}`
`149`	`149`	`else`
`@@ -219,7 +219,7 @@ private void RunLoop()`
`219`	`219`	`}`
`220`	`220`	`catch (Exception ex)`
`221`	`221`	`{`
`222`		`- Logger.Error(ex);`
	`222`	`+ Logger.Error(ex.InnerException ?? ex);`
`223`	`223`	`activeTask.RaiseOnEnd();`
`224`	`224`	`activeTask = null;`
`225`	`225`	`}`