Using string.empty

Author: StanleyGoldman

src/GitHub.Api/Helpers/AssemblyResources.cs

@@ -25,7 +25,7 @@ public static NPath ToFile(ResourceType resourceType, string resource, NPath des
                 : resourceType == ResourceType.Platform ? "PlatformResources"
                 : "Resources";
             var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream(
-                                     String.Format("GitHub.Unity.{0}{1}.{2}", type, os != "" ? "." + os : os, resource));
+                                     String.Format("GitHub.Unity.{0}{1}.{2}", type, !string.IsNullOrEmpty(os) ? "." + os : os, resource));
             if (stream != null)
                 return destinationPath.Combine(resource).WriteAllBytes(stream.ToByteArray());
 

src/GitHub.Api/IO/NiceIO.cs

@@ -222,7 +222,7 @@ public NPath ChangeExtension(string extension)
 
             var newElements = (string[])_elements.Clone();
             newElements[newElements.Length - 1] = FileSystem.ChangeExtension(_elements[_elements.Length - 1], WithDot(extension));
-            if (extension == string.Empty)
+            if (string.IsNullOrEmpty(extension))
                 newElements[newElements.Length - 1] = newElements[newElements.Length - 1].TrimEnd('.');
             return new NPath(newElements, _isRelative, _driveLetter);
         }

src/GitHub.Api/OutputProcessors/LogEntryOutputProcessor.cs

@@ -175,7 +175,7 @@ public override void LineReceived(string line)
                     break;
 
                 case ProcessingPhase.Files:
-                    if (line == string.Empty)
+                    if (string.IsNullOrEmpty(line))
                     {
                         ReturnGitLogEntry();
                         return;

src/UnityExtension/Assets/Editor/GitHub.Unity/ScriptObjectSingleton.cs

@@ -37,7 +37,7 @@ private NPath FilePath
             {
                 if (nFilePath == null)
                 {
-                    if (filePath == "")
+                    if (string.IsNullOrEmpty(filePath))
                         return null;
                     if (filePath == null)
                         filePath = GetFilePath();

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PublishView.cs

@@ -161,7 +161,7 @@ public override void OnGUI()
                         var organization = owners[selectedOwner] == username ? null : owners[selectedOwner];
 
                         var cleanRepoDescription = repoDescription.Trim();
-                        cleanRepoDescription = cleanRepoDescription == string.Empty ? null : cleanRepoDescription;
+                        cleanRepoDescription = string.IsNullOrEmpty(cleanRepoDescription) ? null : cleanRepoDescription;
 
                         Client.CreateRepository(new NewRepository(repoName)
                         {