Merge pull request #369 from github-for-unity/stanley/queueing-watcher-events-tweak

Using TryGet to fire events

Author: shana

src/GitHub.Api/Events/RepositoryWatcher.cs

@@ -367,49 +367,54 @@ private int FireEvents(Dictionary<EventType, List<EventData>> events)
                 eventsProcessed++;
             }
 
-            if (events.ContainsKey(EventType.LocalBranchCreated))
+            List<EventData> localBranchesCreated;
+            if (events.TryGetValue(EventType.LocalBranchCreated, out localBranchesCreated))
             {
-                foreach (var evt in events[EventType.LocalBranchCreated])
+                foreach (var evt in localBranchesCreated)
                 {
                     Logger.Trace($"LocalBranchCreated: {evt.Branch}");
                     LocalBranchCreated?.Invoke(evt.Branch);
                     eventsProcessed++;
                 }
             }
 
-            if (events.ContainsKey(EventType.LocalBranchChanged))
+            List<EventData> localBranchesChanged;
+            if (events.TryGetValue(EventType.LocalBranchChanged, out localBranchesChanged))
             {
-                foreach (var evt in events[EventType.LocalBranchChanged])
+                foreach (var evt in localBranchesChanged)
                 {
                     Logger.Trace($"LocalBranchChanged: {evt.Branch}");
                     LocalBranchChanged?.Invoke(evt.Branch);
                     eventsProcessed++;
                 }
             }
 
-            if (events.ContainsKey(EventType.LocalBranchDeleted))
+            List<EventData> localBranchesDeleted;
+            if (events.TryGetValue(EventType.LocalBranchDeleted, out localBranchesDeleted))
             {
-                foreach (var evt in events[EventType.LocalBranchDeleted])
+                foreach (var evt in localBranchesDeleted)
                 {
                     Logger.Trace($"LocalBranchDeleted: {evt.Branch}");
                     LocalBranchDeleted?.Invoke(evt.Branch);
                     eventsProcessed++;
                 }
             }
 
-            if (events.ContainsKey(EventType.RemoteBranchCreated))
+            List<EventData> remoteBranchesCreated;
+            if (events.TryGetValue(EventType.RemoteBranchCreated, out remoteBranchesCreated))
             {
-                foreach (var evt in events[EventType.RemoteBranchCreated])
+                foreach (var evt in remoteBranchesCreated)
                 {
                     Logger.Trace($"RemoteBranchCreated: {evt.Origin}/{evt.Branch}");
                     RemoteBranchCreated?.Invoke(evt.Origin, evt.Branch);
                     eventsProcessed++;
                 }
             }
 
-            if (events.ContainsKey(EventType.RemoteBranchDeleted))
+            List<EventData> remoteBranchesDeleted;
+            if (events.TryGetValue(EventType.RemoteBranchDeleted, out remoteBranchesDeleted))
             {
-                foreach (var evt in events[EventType.RemoteBranchDeleted])
+                foreach (var evt in remoteBranchesDeleted)
                 {
                     Logger.Trace($"RemoteBranchDeleted: {evt.Origin}/{evt.Branch}");
                     RemoteBranchDeleted?.Invoke(evt.Origin, evt.Branch);