Doing delete with .Net is a whole lot faster

Author: StanleyGoldman

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -128,7 +128,7 @@ public void RestartRepository()
         {
             if (Environment.RepositoryPath != null)
             {
-                repositoryManager = Unity.RepositoryManager.CreateInstance(Platform, TaskManager, GitClient, ProcessManager, Environment.RepositoryPath);
+                repositoryManager = Unity.RepositoryManager.CreateInstance(Platform, TaskManager, GitClient, ProcessManager, Environment.RepositoryPath, Environment.FileSystem);
                 repositoryManager.Initialize();
                 Environment.Repository.Initialize(repositoryManager);
                 repositoryManager.Start();

src/GitHub.Api/Git/RepositoryManager.cs

@@ -100,6 +100,7 @@ class RepositoryManager : IRepositoryManager
         private readonly IGitClient gitClient;
         private readonly IProcessManager processManager;
         private readonly IRepositoryPathConfiguration repositoryPaths;
+        private readonly IFileSystem fileSystem;
         private readonly IRepositoryWatcher watcher;
 
         private bool isBusy;
@@ -116,9 +117,11 @@ class RepositoryManager : IRepositoryManager
         public RepositoryManager(IGitConfig gitConfig,
             IRepositoryWatcher repositoryWatcher, IGitClient gitClient,
             IProcessManager processManager,
-            IRepositoryPathConfiguration repositoryPaths)
+            IRepositoryPathConfiguration repositoryPaths,
+            IFileSystem fileSystem)
         {
             this.repositoryPaths = repositoryPaths;
+            this.fileSystem = fileSystem;
             this.gitClient = gitClient;
             this.processManager = processManager;
             this.watcher = repositoryWatcher;
@@ -127,7 +130,7 @@ public RepositoryManager(IGitConfig gitConfig,
             SetupWatcher();
         }
 
-        public static RepositoryManager CreateInstance(IPlatform platform, ITaskManager taskManager, IGitClient gitClient, IProcessManager processManager, NPath repositoryRoot)
+        public static RepositoryManager CreateInstance(IPlatform platform, ITaskManager taskManager, IGitClient gitClient, IProcessManager processManager, NPath repositoryRoot, IFileSystem fileSystem)
         {
             var repositoryPathConfiguration = new RepositoryPathConfiguration(repositoryRoot);
             string filePath = repositoryPathConfiguration.DotGitConfig;
@@ -136,7 +139,7 @@ public static RepositoryManager CreateInstance(IPlatform platform, ITaskManager
             var repositoryWatcher = new RepositoryWatcher(platform, repositoryPathConfiguration, taskManager.Token);
 
             return new RepositoryManager(gitConfig, repositoryWatcher,
-                gitClient, processManager, repositoryPathConfiguration);
+                gitClient, processManager, repositoryPathConfiguration, fileSystem);
         }
 
         public void Initialize()
@@ -298,17 +301,16 @@ public ITask CheckoutFiles(List<string> files)
 
         public ITask DeleteFiles(List<string> list)
         {
-            ITask<List<string>> task = new DeleteFilesExecTask(list.ToArray(), CancellationToken.None)
-                .Configure(processManager);
-
-            task = HookupHandlers(task, true, true);
-
-            var @finally = task.Finally((b, exception, arg3) => {
-                Logger.Trace("Delete Files success:{0} output: {1}", b, arg3 != null ? string.Join(",", arg3.ToArray()) : "[NULL]");
+            var delete = new ActionTask(CancellationToken.None, () => {
+                for (var index = 0; index < list.Count; index++)
+                {
+                    fileSystem.FileDelete(list[index]);
+                }
             });
 
-            return @finally
-                .Start();
+            delete.OnStart += t => IsBusy = true;
+
+            return delete.Finally(() => IsBusy = false);
         }
 
         public void UpdateGitAheadBehindStatus()

src/GitHub.Api/GitHub.Api.csproj

@@ -147,7 +147,6 @@
     <Compile Include="Tasks\TaskCanceledExceptions.cs" />
     <Compile Include="Tasks\TaskExtensions.cs" />
     <Compile Include="Tasks\TaskManager.cs" />
-    <Compile Include="Platform\DeleteFilesExecTask.cs" />
     <Compile Include="Platform\FindExecTask.cs" />
     <Compile Include="Helpers\Progress.cs" />
     <Compile Include="Metrics\IMetricsService.cs" />

src/GitHub.Api/Platform/DeleteFilesExecTask.cs

@@ -14,7 +14,7 @@ protected IEnvironment Initialize(NPath repoPath, NPath environmentPath = null,
         {
             InitializePlatform(repoPath, environmentPath, enableEnvironmentTrace);
 
-            var repositoryManager = GitHub.Unity.RepositoryManager.CreateInstance(Platform, TaskManager, GitClient, ProcessManager, repoPath);
+            var repositoryManager = GitHub.Unity.RepositoryManager.CreateInstance(Platform, TaskManager, GitClient, ProcessManager, repoPath, Environment.FileSystem);
             onRepositoryManagerCreated?.Invoke(repositoryManager);
 
             RepositoryManager = repositoryManager;