Adding some extension to spool strings

Author: StanleyGoldman

src/GitHub.Api/Extensions/ListExtensions.cs

@@ -0,0 +1,44 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+
+namespace GitHub.Unity
+{
+    public static class ListExtensions
+    {
+        public static string Join<T>(this IEnumerable<T> list, string separator)
+        {
+            if (list == null)
+                return null;
+            return String.Join(separator, list.Select(x => x?.ToString()).ToArray());
+        }
+        
+        public static IEnumerable<IList<string>> Spool<T>(this IEnumerable<T> items, int spoolLength)
+        {
+            var currentSpoolLength = 0;
+            var currentList= new List<string>();
+
+            foreach (var item in items)
+            {
+                var itemValue = item.ToString();
+                var itemValueLength = itemValue.Length;
+
+                if (currentSpoolLength + itemValueLength > spoolLength)
+                {
+                    yield return currentList;
+
+                    currentSpoolLength = 0;
+                    currentList = new List<string>();
+                }
+
+                currentSpoolLength += itemValueLength;
+                currentList.Add(itemValue);
+            }
+
+            if (currentList.Any())
+            {
+                yield return currentList;
+            }
+        }
+    }
+}

src/GitHub.Api/Extensions/StringExtensions.cs

@@ -151,16 +151,6 @@ public static string LeftBeforeLast(this string s, char search)
         }
     }
 
-    public static class ListExtensions
-    {
-        public static string Join<T>(this IEnumerable<T> list, string separator)
-        {
-            if (list == null)
-                return null;
-            return String.Join(separator, list.Select(x => x?.ToString()).ToArray());
-        }
-    }
-
     public struct StringResult
     {
         public string Chunk;

src/GitHub.Api/GitHub.Api.csproj

@@ -96,6 +96,7 @@
     <Compile Include="Application\ApplicationInfo.cs" />
     <Compile Include="Application\LoginResult.cs" />
     <Compile Include="Application\AppConfiguration.cs" />
+    <Compile Include="Extensions\ListExtensions.cs" />
     <Compile Include="Helpers\AssemblyResources.cs" />
     <Compile Include="Authentication\IKeychain.cs" />
     <Compile Include="Authentication\Keychain.cs" />

src/tests/UnitTests/Extensions/ListExtensionTests.cs

@@ -0,0 +1,28 @@
+using System.Linq;
+using FluentAssertions;
+using GitHub.Unity;
+using NUnit.Framework;
+
+namespace UnitTests
+{
+    [TestFixture]
+    public class ListExtensionTests
+    {
+        [Test]
+        public void SpoolTest()
+        {
+            var results = new[] { "qwer", "asdf", "zxcv", "wert", "1234" }.Spool(10).ToArray();
+            results.Length.Should().Be(3);
+            results[0].Count.Should().Be(2);
+            results[0][0].Should().Be("qwer");
+            results[0][1].Should().Be("asdf");
+
+            results[1].Count.Should().Be(2);
+            results[1][0].Should().Be("zxcv");
+            results[1][1].Should().Be("wert");
+
+            results[2].Count.Should().Be(1);
+            results[2][0].Should().Be("1234");
+        }
+    }
+}

src/tests/UnitTests/UnitTests.csproj

@@ -81,6 +81,7 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="Authentication\KeychainTests.cs" />
+    <Compile Include="Extensions\ListExtensionTests.cs" />
     <Compile Include="Git\ValidationTests.cs" />
     <Compile Include="Git\GitConfigTests.cs" />
     <Compile Include="IO\BranchListOutputProcessorTests.cs" />