Fix nulls being passed around

Author: shana

src/GitHub.Api/Application/ApiClient.cs

@@ -32,11 +32,7 @@ public ApiClient(UriString hostUrl, IKeychain keychain, IProcessManager processM
             this.taskManager = taskManager;
             this.nodeJsExecutablePath = nodeJsExecutablePath;
             this.octorunScriptPath = octorunScriptPath;
-            loginManager = new LoginManager(keychain,
-                processManager: processManager,
-                taskManager: taskManager,
-                nodeJsExecutablePath: nodeJsExecutablePath,
-                octorunScript: octorunScriptPath);
+            loginManager = new LoginManager(keychain, processManager, taskManager, nodeJsExecutablePath, octorunScriptPath);
         }
 
         public ITask Logout(UriString host)

src/GitHub.Api/Authentication/LoginManager.cs

@@ -34,7 +34,7 @@ class LoginManager : ILoginManager
         /// <param name="nodeJsExecutablePath"></param>
         /// <param name="octorunScript"></param>
         public LoginManager(
-            IKeychain keychain, IProcessManager processManager = null, ITaskManager taskManager = null,
+            IKeychain keychain, IProcessManager processManager, ITaskManager taskManager,
             NPath? nodeJsExecutablePath = null, NPath? octorunScript = null)
         {
             Guard.ArgumentNotNull(keychain, nameof(keychain));

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

@@ -816,7 +816,7 @@ private void SignOut(object obj)
                 host = UriString.ToUriString(HostAddress.GitHubDotComHostAddress.WebUri);
             }
 
-            var apiClient = new ApiClient(host, Platform.Keychain, null, null, NPath.Default, NPath.Default);
+            var apiClient = new ApiClient(host, Platform.Keychain, Manager.ProcessManager, Manager.TaskManager, Environment.NodeJsExecutablePath, Environment.OctorunScriptPath);
             apiClient.Logout(host);
         }