Fix octorun version check sigh

shana · shana · commit 39f334eab721 · 2018-05-31T19:29:04.000+02:00
diff --git a/src/GitHub.Api/Installer/OctorunInstaller.cs b/src/GitHub.Api/Installer/OctorunInstaller.cs
@@ -71,7 +71,7 @@ private bool IsOctorunExtracted()
                 return false;
             }
 
-            var octorunVersion = installDetails.VersionFile.ReadAllText();
+            var octorunVersion = installDetails.VersionFile.ReadAllText().Trim();
             if (!OctorunInstallDetails.PackageVersion.Equals(octorunVersion))
             {
                 Logger.Warning("Current version {0} does not match expected {1}", octorunVersion, OctorunInstallDetails.PackageVersion);
@@ -112,4 +112,4 @@ public OctorunInstallDetails(NPath baseDataPath)
             public NPath VersionFile => InstallationPath.Combine("version");
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ private bool IsOctorunExtracted()`
`71`	`71`	`return false;`
`72`	`72`	`}`
`73`	`73`
`74`		`- var octorunVersion = installDetails.VersionFile.ReadAllText();`
	`74`	`+ var octorunVersion = installDetails.VersionFile.ReadAllText().Trim();`
`75`	`75`	`if (!OctorunInstallDetails.PackageVersion.Equals(octorunVersion))`
`76`	`76`	`{`
`77`	`77`	`Logger.Warning("Current version {0} does not match expected {1}", octorunVersion, OctorunInstallDetails.PackageVersion);`
`@@ -112,4 +112,4 @@ public OctorunInstallDetails(NPath baseDataPath)`
`112`	`112`	`public NPath VersionFile => InstallationPath.Combine("version");`
`113`	`113`	`}`
`114`	`114`	`}`
`115`		`-}`
	`115`	`+}`