Merge pull request #565 from github-for-unity/fixes/debug-prevent-log-roll

StanleyGoldman · web-flow · commit 40e7b128c22f · 2018-01-12T14:09:49.000-05:00
Retain logs when developing
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/EntryPoint.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/EntryPoint.cs
@@ -40,10 +40,17 @@ private static void Initialize()
                 var oldLogPath = logPath.Parent.Combine(logPath.FileNameWithoutExtension + "-old" + logPath.ExtensionWithDot);
                 try
                 {
-                    oldLogPath.DeleteIfExists();
-                    if (logPath.FileExists())
+                    var shouldRotate = true;
+#if DEVELOPER_BUILD
+                    shouldRotate = new FileInfo(logPath).Length > 10 * 1024 * 1024;
+#endif
+                    if (shouldRotate)
                     {
-                        logPath.Move(oldLogPath);
+                        oldLogPath.DeleteIfExists();
+                        if (logPath.FileExists())
+                        {
+                            logPath.Move(oldLogPath);
+                        }
                     }
                 }
                 catch (Exception ex)

Original file line number	Diff line number	Diff line change
`@@ -40,10 +40,17 @@ private static void Initialize()`
`40`	`40`	`var oldLogPath = logPath.Parent.Combine(logPath.FileNameWithoutExtension + "-old" + logPath.ExtensionWithDot);`
`41`	`41`	`try`
`42`	`42`	`{`
`43`		`- oldLogPath.DeleteIfExists();`
`44`		`- if (logPath.FileExists())`
	`43`	`+ var shouldRotate = true;`
	`44`	`+#if DEVELOPER_BUILD`
	`45`	`+ shouldRotate = new FileInfo(logPath).Length > 10 * 1024 * 1024;`
	`46`	`+#endif`
	`47`	`+ if (shouldRotate)`
`45`	`48`	`{`
`46`		`- logPath.Move(oldLogPath);`
	`49`	`+ oldLogPath.DeleteIfExists();`
	`50`	`+ if (logPath.FileExists())`
	`51`	`+ {`
	`52`	`+ logPath.Move(oldLogPath);`
	`53`	`+ }`
`47`	`54`	`}`
`48`	`55`	`}`
`49`	`56`	`catch (Exception ex)`