Starting the task and handling isBusy

Author: StanleyGoldman

src/GitHub.Api/Helpers/Constants.cs

@@ -8,7 +8,7 @@ static class Constants
         public const string GitInstallPathKey = "GitInstallPath";
         public const string TraceLoggingKey = "EnableTraceLogging";
 
-        public static readonly SoftwareVersion MinimumGitVersion = new SoftwareVersion(2, 1, 0);
-        public static readonly SoftwareVersion MinimumGitLfsVersion = new SoftwareVersion(2, 1, 0);
+        public static readonly SoftwareVersion MinimumGitVersion = new SoftwareVersion(2, 12, 2);
+        public static readonly SoftwareVersion MinimumGitLfsVersion = new SoftwareVersion(2, 0, 2);
     }
 }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/GitPathView.cs

@@ -91,8 +91,6 @@ public override void OnGUI()
                     {
                         if (GUILayout.Button(GitPathSaveButton, GUILayout.ExpandWidth(false)))
                         {
-                            Logger.Trace("Saving Git Path:{0}", newGitExec);
-
                             GUI.FocusControl(null);
 
                             ValidateAndSetGitInstallPath(newGitExec);
@@ -130,8 +128,6 @@ public override void OnGUI()
                                 {
                                     ValidateAndSetGitInstallPath(path);
                                 }
-
-                                isBusy = false;
                             }).Start();
                     }
                 }
@@ -142,24 +138,30 @@ public override void OnGUI()
 
         private void ValidateAndSetGitInstallPath(string value)
         {
-            GitClient.ValidateGitInstall(value).Then((sucess, result) => {
+            Logger.Trace("Validating Git Path:{0}", value);
+
+            GitClient.ValidateGitInstall(value).ThenInUI((sucess, result) => {
                 if (!sucess)
                 {
                     Logger.Trace("Error getting software versions");
+                    isBusy = false;
                     return;
                 }
 
                 if (!result.IsValid)
                 {
                     Logger.Warning("Software versions do not meet minimums Git:{0} GitLfs:{1}", result.GitVersionTask, result.GitLfsVersionTask);
+                    isBusy = false;
                     return;
                 }
 
                 Manager.SystemSettings.Set(Constants.GitInstallPathKey, value);
                 Environment.GitExecutablePath = value.ToNPath();
 
                 gitExecHasChanged = true;
-            });
+                isBusy = false;
+
+            }).Start();
         }
 
         private void MaybeUpdateData()