Remove regex processing of special error cases

Author: StanleyGoldman

octorun/src/authentication.js

@@ -2,9 +2,7 @@ var endOfLine = require('os').EOL;
 var config = require("./configuration");
 var octokitWrapper = require("./octokit");
 
-var lockedRegex = new RegExp("number of login attempts exceeded", "gi");
 var twoFactorRegex = new RegExp("must specify two-factor authentication otp code", "gi");
-var badCredentialsRegex = new RegExp("bad credentials", "gi");
 
 var scopes = ["user", "repo", "gist", "write:public_key"];
 
@@ -48,12 +46,6 @@ var handleAuthentication = function (username, password, onSuccess, onFailure, t
             else if (twoFactorRegex.test(err.message)) {
                 onSuccess(password, "2fa");
             }
-            else if (lockedRegex.test(err.message)) {
-                onFailure("locked")
-            }
-            else if (badCredentialsRegex.test(err.message)) {
-                onFailure("badcredentials")
-            }
             else {
                 onFailure(err)
             }

octorun/version

@@ -1 +1 @@
-8bc23505
+196e9867

src/GitHub.Api/Authentication/LoginManager.cs

@@ -193,19 +193,9 @@ private async Task<LoginResultData> TryLogin(
                 return new LoginResultData(resultCodes, message, host, ret.Output[0]);
             }
 
-            if (ret.IsBadCredentials)
-            {
-                return new LoginResultData(LoginResultCodes.Failed, "Bad credentials.", host, ret.Output[0]);
-            }
-
-            if (ret.IsLocked)
-            {
-                return new LoginResultData(LoginResultCodes.LockedOut, "Account locked.", host, ret.Output[0]);
-            }
-
             if (ret.Output.Any())
             {
-                return new LoginResultData(LoginResultCodes.Failed, "Failed.", host, ret.Output[0]);
+                return new LoginResultData(LoginResultCodes.Failed, ret.Output[0], host);
             }
 
             return new LoginResultData(LoginResultCodes.Failed, "Failed.", host);

src/GitHub.Api/Installer/OctorunInstaller.cs

@@ -102,7 +102,7 @@ public class OctorunInstallDetails
             public const string DefaultZipMd5Url = "https://ghfvs-installer.github.com/unity/octorun/octorun.zip.md5";
             public const string DefaultZipUrl = "https://ghfvs-installer.github.com/unity/octorun/octorun.zip";
 
-            public const string PackageVersion = "8bc23505";
+            public const string PackageVersion = "196e9867";
             private const string PackageName = "octorun";
             private const string zipFile = "octorun.zip";
 

src/GitHub.Api/Resources/octorun.zip

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:c56b2f70a9449004489117844e6894a4541001ed20a6fb63bfc9aeacfd419010
-size 211930
+oid sha256:b88a832fae41b944798323b91a745909bbf7d083fdf2455e2ec71dd51030523a
+size 211853

src/GitHub.Api/Tasks/OctorunTask.cs

@@ -132,7 +132,5 @@ public OctorunResult(string status, string[] output)
         public bool IsSuccess => Status.Equals("success", StringComparison.InvariantCultureIgnoreCase);
         public bool IsError => Status.Equals("error", StringComparison.InvariantCultureIgnoreCase);
         public bool IsTwoFactorRequired => Status.Equals("2fa", StringComparison.InvariantCultureIgnoreCase);
-        public bool IsLocked => Output.First().Equals("locked", StringComparison.InvariantCultureIgnoreCase);
-        public bool IsBadCredentials => Output.First().Equals("badcredentials", StringComparison.InvariantCultureIgnoreCase);
     }
 }