Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 54d78cb

Browse files
committed
Fix warnings and broken metrics service
1 parent f7a0b44 commit 54d78cb

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

src/GitHub.Api/Application/ApplicationManagerBase.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ protected void SetupMetrics(string unityVersion, bool firstRun)
174174
id = Guid.NewGuid().ToString();
175175
UserSettings.Set(Constants.GuidKey, id);
176176
}
177-
177+
/*
178178
var metricsService = new MetricsService(ProcessManager,
179179
TaskManager,
180180
Environment.FileSystem,
@@ -187,6 +187,7 @@ protected void SetupMetrics(string unityVersion, bool firstRun)
187187
{
188188
UsageTracker.IncrementLaunchCount();
189189
}
190+
*/
190191
}
191192

192193
protected abstract void SetupMetrics();

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BaseWindow.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public virtual void OnUI() {}
7575
// This is Unity's magic method
7676
private void OnGUI()
7777
{
78-
if (Event.current.type == EventType.layout)
78+
if (Event.current.type == EventType.Layout)
7979
{
8080
if (cachedRepository != Environment.Repository || initializeWasCalled)
8181
{
@@ -89,7 +89,7 @@ private void OnGUI()
8989

9090
OnUI();
9191

92-
if (Event.current.type == EventType.repaint)
92+
if (Event.current.type == EventType.Repaint)
9393
{
9494
inLayout = false;
9595
}

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/TreeControl.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ public TreeNodeRenderResult Render(Rect rect, float indentation, bool isSelected
465465

466466
var contentStyle = IsActive ? activeNodeStyle : nodeStyle;
467467

468-
if (Event.current.type == EventType.repaint)
468+
if (Event.current.type == EventType.Repaint)
469469
{
470470
contentStyle.Draw(fillRect, GUIContent.none, false, false, false, isSelected);
471471
}
@@ -475,7 +475,7 @@ public TreeNodeRenderResult Render(Rect rect, float indentation, bool isSelected
475475
{
476476
styleOn = !IsCollapsed;
477477

478-
if (Event.current.type == EventType.repaint)
478+
if (Event.current.type == EventType.Repaint)
479479
{
480480
toggleStyle.Draw(toggleRect, GUIContent.none, false, false, styleOn, isSelected);
481481
}
@@ -514,7 +514,7 @@ public TreeNodeRenderResult Render(Rect rect, float indentation, bool isSelected
514514
}
515515
}
516516

517-
if (Event.current.type == EventType.repaint)
517+
if (Event.current.type == EventType.Repaint)
518518
{
519519
contentStyle.Draw(iconRect, content, false, false, false, isSelected);
520520
}

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ public override void OnUI()
210210
ActiveView.OnGUI();
211211
}
212212

213-
if (IsBusy && activeTab != SubTab.Settings && Event.current.type == EventType.repaint)
213+
if (IsBusy && activeTab != SubTab.Settings && Event.current.type == EventType.Repaint)
214214
{
215215
if (timeSinceLastRotation < 0)
216216
{

0 commit comments

Comments
 (0)