Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 5a2be0e

Browse files
Merge branch 'master' into enhancements/initialize-view
2 parents 24aa102 + 4fb5946 commit 5a2be0e

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/GitHub.Api/NewTaskSystem/ProcessTask.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,8 @@ protected override T RunWithReturn(bool success)
288288
if (outputProcessor != null)
289289
result = outputProcessor.Result;
290290

291-
if (result == null && typeof(T) == typeof(string))
292-
result = (T)(object)(Process.StartInfo.CreateNoWindow ? "Process finished" : "Process running");
291+
if (result == null && !Process.StartInfo.CreateNoWindow && typeof(T) == typeof(string))
292+
result = (T)(object)"Process running";
293293

294294
RaiseOnEnd(result);
295295

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/AuthenticationWindow.cs.meta renamed to src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cs.meta

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/tests/IntegrationTests/Process/ProcessManagerIntegrationTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ public async Task CredentialHelperGetTest()
179179
s = await ProcessManager
180180
.GetGitCreds(TestRepoMasterCleanSynchronized, Environment, GitEnvironment)
181181
.StartAsAsync();
182-
s.Should().NotBeNull();
183182
}
184183
}
185184
}

0 commit comments

Comments
 (0)