Instance should never be null

StanleyGoldman · StanleyGoldman · commit 5a5c63fa5569 · 2017-05-22T11:51:58.000-04:00
diff --git a/src/GitHub.Logging/Logging.cs b/src/GitHub.Logging/Logging.cs
@@ -85,77 +85,77 @@ public static ILogging GetLogger(string context = null)
 
         public static void Info(string s)
         {
-            Instance?.Info(s);
+            Instance.Info(s);
         }
 
         public static void Debug(string s)
         {
-            Instance?.Debug(s);
+            Instance.Debug(s);
         }
 
         public static void Trace(string s)
         {
-            Instance?.Trace(s);
+            Instance.Trace(s);
         }
 
         public static void Warning(string s)
         {
-            Instance?.Warning(s);
+            Instance.Warning(s);
         }
 
         public static void Error(string s)
         {
-            Instance?.Error(s);
+            Instance.Error(s);
         }
 
         public static void Info(string format, params object[] objects)
         {
-            Instance?.Info(format, objects);
+            Instance.Info(format, objects);
         }
 
         public static void Debug(string format, params object[] objects)
         {
-            Instance?.Debug(format, objects);
+            Instance.Debug(format, objects);
         }
 
         public static void Trace(string format, params object[] objects)
         {
-            Instance?.Trace(format, objects);
+            Instance.Trace(format, objects);
         }
 
         public static void Warning(string format, params object[] objects)
         {
-            Instance?.Warning(format, objects);
+            Instance.Warning(format, objects);
         }
 
         public static void Error(string format, params object[] objects)
         {
-            Instance?.Error(format, objects);
+            Instance.Error(format, objects);
         }
 
         public static void Info(Exception ex, string s)
         {
-            Instance?.Info(ex, s);
+            Instance.Info(ex, s);
         }
 
         public static void Debug(Exception ex, string s)
         {
-            Instance?.Debug(ex, s);
+            Instance.Debug(ex, s);
         }
 
         public static void Trace(Exception ex, string s)
         {
-            Instance?.Trace(ex, s);
+            Instance.Trace(ex, s);
         }
 
         public static void Warning(Exception ex, string s)
         {
-            Instance?.Warning(ex, s);
+            Instance.Warning(ex, s);
         }
 
         public static void Error(Exception ex, string s)
         {
-            Instance?.Error(ex, s);
+            Instance.Error(ex, s);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -85,77 +85,77 @@ public static ILogging GetLogger(string context = null)`
`85`	`85`
`86`	`86`	`public static void Info(string s)`
`87`	`87`	`{`
`88`		`- Instance?.Info(s);`
	`88`	`+ Instance.Info(s);`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`public static void Debug(string s)`
`92`	`92`	`{`
`93`		`- Instance?.Debug(s);`
	`93`	`+ Instance.Debug(s);`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`public static void Trace(string s)`
`97`	`97`	`{`
`98`		`- Instance?.Trace(s);`
	`98`	`+ Instance.Trace(s);`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`public static void Warning(string s)`
`102`	`102`	`{`
`103`		`- Instance?.Warning(s);`
	`103`	`+ Instance.Warning(s);`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`public static void Error(string s)`
`107`	`107`	`{`
`108`		`- Instance?.Error(s);`
	`108`	`+ Instance.Error(s);`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`public static void Info(string format, params object[] objects)`
`112`	`112`	`{`
`113`		`- Instance?.Info(format, objects);`
	`113`	`+ Instance.Info(format, objects);`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`public static void Debug(string format, params object[] objects)`
`117`	`117`	`{`
`118`		`- Instance?.Debug(format, objects);`
	`118`	`+ Instance.Debug(format, objects);`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`public static void Trace(string format, params object[] objects)`
`122`	`122`	`{`
`123`		`- Instance?.Trace(format, objects);`
	`123`	`+ Instance.Trace(format, objects);`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`public static void Warning(string format, params object[] objects)`
`127`	`127`	`{`
`128`		`- Instance?.Warning(format, objects);`
	`128`	`+ Instance.Warning(format, objects);`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`public static void Error(string format, params object[] objects)`
`132`	`132`	`{`
`133`		`- Instance?.Error(format, objects);`
	`133`	`+ Instance.Error(format, objects);`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`public static void Info(Exception ex, string s)`
`137`	`137`	`{`
`138`		`- Instance?.Info(ex, s);`
	`138`	`+ Instance.Info(ex, s);`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`public static void Debug(Exception ex, string s)`
`142`	`142`	`{`
`143`		`- Instance?.Debug(ex, s);`
	`143`	`+ Instance.Debug(ex, s);`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`public static void Trace(Exception ex, string s)`
`147`	`147`	`{`
`148`		`- Instance?.Trace(ex, s);`
	`148`	`+ Instance.Trace(ex, s);`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`public static void Warning(Exception ex, string s)`
`152`	`152`	`{`
`153`		`- Instance?.Warning(ex, s);`
	`153`	`+ Instance.Warning(ex, s);`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`public static void Error(Exception ex, string s)`
`157`	`157`	`{`
`158`		`- Instance?.Error(ex, s);`
	`158`	`+ Instance.Error(ex, s);`
`159`	`159`	`}`
`160`	`160`	`}`
`161`	`161`	`}`