Clearing the message at the right time

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/AuthenticationView.cs

@@ -21,15 +21,15 @@ class AuthenticationView : Subview
         private const string TwofaButton = "Verify";
 
         [SerializeField] private Vector2 scroll;
-        [SerializeField] private string username = "";
-        [SerializeField] private string two2fa = "";
+        [SerializeField] private string username = string.Empty;
+        [SerializeField] private string two2fa = string.Empty;
         [SerializeField] private string message;
 
         [NonSerialized] private bool need2fa;
         [NonSerialized] private bool isBusy;
         [NonSerialized] private string errorMessage;
         [NonSerialized] private bool enterPressed;
-        [NonSerialized] private string password = "";
+        [NonSerialized] private string password = string.Empty;
         [NonSerialized] private AuthenticationService authenticationService;
 
 
@@ -104,11 +104,21 @@ public void SetMessage(string value)
             message = value;
         }
 
+        public void ClearMessage()
+        {
+            message = null;
+        }
+
         public void SetUsername(string value)
         {
             username = value;
         }
 
+        public void ClearUsername()
+        {
+            username = string.Empty;
+        }
+
         private void HandleEnterPressed()
         {
             if (Event.current.type != EventType.KeyDown)

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cs

@@ -83,6 +83,9 @@ private void Open(PopupViewType popupViewType, Action<bool> onClose)
                     }
 
                     OpenInternal(PopupViewType.AuthenticationView, completedAuthentication => {
+                        authenticationView.ClearMessage();
+                        authenticationView.ClearUsername();
+
                         if (completedAuthentication)
                         {
                             Logger.Trace("User completed validation opening view: {0}", popupViewType.ToString());