Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 62cbe4b

Browse files
Merge branch 'master' into features/lock-files-view
2 parents d823cf8 + c086434 commit 62cbe4b

File tree

8 files changed

+51
-20
lines changed

8 files changed

+51
-20
lines changed

src/GitHub.Api/Git/IRepository.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,5 +78,6 @@ public interface IRepository : IEquatable<IRepository>, IDisposable
7878
ITask DeleteBranch(string branch, bool force);
7979
ITask CreateBranch(string branch, string baseBranch);
8080
ITask SwitchBranch(string branch);
81+
void Refresh(CacheType cacheType);
8182
}
8283
}

src/GitHub.Api/Git/Repository.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,16 @@ public bool Equals(IRepository other)
162162

163163
private void RefreshCache(CacheType cacheType)
164164
{
165-
taskManager.RunInUI(() =>
165+
taskManager.RunInUI(() => Refresh(cacheType));
166+
}
167+
168+
public void Refresh(CacheType cacheType)
166169
{
167170
var cache = cacheContainer.GetCache(cacheType);
168171
// if the cache has valid data, we need to force an invalidation to refresh it
169172
// if it doesn't have valid data, it will trigger an invalidation automatically
170173
if (cache.ValidateData())
171174
cache.InvalidateData();
172-
});
173175
}
174176

175177
private void CacheHasBeenInvalidated(CacheType cacheType)

src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Styles.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class Styles
6666
headerRepoLabelStyle,
6767
headerTitleStyle,
6868
headerDescriptionStyle,
69-
historyToolbarButtonStyle,
69+
toolbarButtonStyle,
7070
historyLockStyle,
7171
historyEntrySummaryStyle,
7272
historyEntryDetailsStyle,
@@ -382,18 +382,18 @@ public static GUIStyle LongMessageStyle
382382
}
383383
}
384384

385-
public static GUIStyle HistoryToolbarButtonStyle
385+
public static GUIStyle ToolbarButtonStyle
386386
{
387387
get
388388
{
389-
if (historyToolbarButtonStyle == null)
389+
if (toolbarButtonStyle == null)
390390
{
391-
historyToolbarButtonStyle = new GUIStyle(EditorStyles.toolbarButton);
392-
historyToolbarButtonStyle.name = "HistoryToolbarButtonStyle";
393-
historyToolbarButtonStyle.richText = true;
394-
historyToolbarButtonStyle.wordWrap = true;
391+
toolbarButtonStyle = new GUIStyle(EditorStyles.toolbarButton);
392+
toolbarButtonStyle.name = "HistoryToolbarButtonStyle";
393+
toolbarButtonStyle.richText = true;
394+
toolbarButtonStyle.wordWrap = true;
395395
}
396-
return historyToolbarButtonStyle;
396+
return toolbarButtonStyle;
397397
}
398398
}
399399

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BranchesView.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,13 @@ public override void OnDisable()
9292
DetachHandlers(Repository);
9393
}
9494

95+
public override void Refresh()
96+
{
97+
base.Refresh();
98+
Repository.Refresh(CacheType.Branches);
99+
Repository.Refresh(CacheType.RepositoryInfo);
100+
}
101+
95102
public override void OnDataUpdate()
96103
{
97104
base.OnDataUpdate();

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesView.cs

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,14 @@ public override void OnDisable()
6060
DetachHandlers(Repository);
6161
}
6262

63+
public override void Refresh()
64+
{
65+
base.Refresh();
66+
Repository.Refresh(CacheType.GitStatus);
67+
Repository.Refresh(CacheType.RepositoryInfo);
68+
Repository.Refresh(CacheType.GitLocks);
69+
}
70+
6371
public override void OnDataUpdate()
6472
{
6573
base.OnDataUpdate();
@@ -355,10 +363,10 @@ private void Commit()
355363
if (success)
356364
{
357365
TaskManager.Run(UsageTracker.IncrementChangesViewButtonCommit);
358-
}
359366

360-
commitMessage = "";
361-
commitBody = "";
367+
commitMessage = "";
368+
commitBody = "";
369+
}
362370
}).Start();
363371
}
364372
}

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,13 @@ public override void OnDisable()
345345
DetachHandlers(Repository);
346346
}
347347

348+
public override void Refresh()
349+
{
350+
base.Refresh();
351+
Repository.Refresh(CacheType.GitLog);
352+
Repository.Refresh(CacheType.GitAheadBehind);
353+
}
354+
348355
public override void OnDataUpdate()
349356
{
350357
base.OnDataUpdate();
@@ -389,11 +396,11 @@ public override void OnGUI()
389396
// Top bar for scrolling to selection or clearing it
390397
GUILayout.BeginHorizontal(EditorStyles.toolbar);
391398
{
392-
if (GUILayout.Button(CommitDetailsTitle, Styles.HistoryToolbarButtonStyle))
399+
if (GUILayout.Button(CommitDetailsTitle, Styles.ToolbarButtonStyle))
393400
{
394401
historyControl.ScrollTo(historyControl.SelectedIndex);
395402
}
396-
if (GUILayout.Button(ClearSelectionButton, Styles.HistoryToolbarButtonStyle, GUILayout.ExpandWidth(false)))
403+
if (GUILayout.Button(ClearSelectionButton, Styles.ToolbarButtonStyle, GUILayout.ExpandWidth(false)))
397404
{
398405
selectedEntry = GitLogEntry.Default;
399406
historyControl.SelectedIndex = -1;

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ public override void Refresh()
8181
base.Refresh();
8282
gitPathView.Refresh();
8383
userSettingsView.Refresh();
84+
if (Repository != null)
85+
Repository.Refresh(CacheType.GitLocks);
8486
}
8587

8688
public override void OnGUI()

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -486,15 +486,15 @@ private void DoActionbarGUI()
486486
EditorGUI.BeginDisabledGroup(currentRemoteName == null);
487487
{
488488
// Fetch button
489-
var fetchClicked = GUILayout.Button(Localization.FetchButtonText, Styles.HistoryToolbarButtonStyle);
489+
var fetchClicked = GUILayout.Button(Localization.FetchButtonText, Styles.ToolbarButtonStyle);
490490
if (fetchClicked)
491491
{
492492
Fetch();
493493
}
494494

495495
// Pull button
496496
var pullButtonText = statusBehind > 0 ? String.Format(Localization.PullButtonCount, statusBehind) : Localization.PullButton;
497-
var pullClicked = GUILayout.Button(pullButtonText, Styles.HistoryToolbarButtonStyle);
497+
var pullClicked = GUILayout.Button(pullButtonText, Styles.ToolbarButtonStyle);
498498

499499
if (pullClicked &&
500500
EditorUtility.DisplayDialog(Localization.PullConfirmTitle,
@@ -512,7 +512,7 @@ private void DoActionbarGUI()
512512
EditorGUI.BeginDisabledGroup(currentRemoteName == null || statusBehind != 0);
513513
{
514514
var pushButtonText = statusAhead > 0 ? String.Format(Localization.PushButtonCount, statusAhead) : Localization.PushButton;
515-
var pushClicked = GUILayout.Button(pushButtonText, Styles.HistoryToolbarButtonStyle);
515+
var pushClicked = GUILayout.Button(pushButtonText, Styles.ToolbarButtonStyle);
516516

517517
if (pushClicked &&
518518
EditorUtility.DisplayDialog(Localization.PushConfirmTitle,
@@ -529,13 +529,17 @@ private void DoActionbarGUI()
529529
else
530530
{
531531
// Publishing a repo
532-
var publishedClicked = GUILayout.Button(Localization.PublishButton, Styles.HistoryToolbarButtonStyle);
533-
if (publishedClicked)
532+
if (GUILayout.Button(Localization.PublishButton, Styles.ToolbarButtonStyle))
534533
{
535534
PopupWindow.OpenWindow(PopupWindow.PopupViewType.PublishView);
536535
}
537536
}
538537

538+
if (GUILayout.Button(Localization.RefreshButton, Styles.ToolbarButtonStyle))
539+
{
540+
Refresh();
541+
}
542+
539543
GUILayout.FlexibleSpace();
540544

541545
if (GUILayout.Button("Account", EditorStyles.toolbarDropDown))

0 commit comments

Comments
 (0)