Merge branch 'fixes/application-cache-initial-times' into fixes/split-status-cache

StanleyGoldman · StanleyGoldman · commit 634609856f6f · 2017-12-04T16:00:55.000-05:00
diff --git a/src/GitHub.Api/Git/ManagedCacheExtensions.cs b/src/GitHub.Api/Git/ManagedCacheExtensions.cs
diff --git a/src/GitHub.Api/Git/Repository.cs b/src/GitHub.Api/Git/Repository.cs
@@ -111,31 +111,31 @@ public ITask ReleaseLock(string file, bool force)
         public void CheckLogChangedEvent(CacheUpdateEvent cacheUpdateEvent)
         {
             var managedCache = cacheContainer.GitLogCache;
-            var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);
+            var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;
 
             Logger.Trace("Check GitLogCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,
-                cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);
+                cacheUpdateEvent.UpdatedTime, raiseEvent);
 
             if (raiseEvent)
             {
                 var dateTimeOffset = managedCache.LastUpdatedAt;
-                var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };
+                var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };
                 HandleGitLogCacheUpdatedEvent(updateEvent);
             }
         }
 
         public void CheckStatusChangedEvent(CacheUpdateEvent cacheUpdateEvent)
         {
             var managedCache = cacheContainer.GitStatusCache;
-            var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);
+            var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;
 
             Logger.Trace("Check GitStatusCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,
-                cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);
+                cacheUpdateEvent.UpdatedTime, raiseEvent);
 
             if (raiseEvent)
             {
                 var dateTimeOffset = managedCache.LastUpdatedAt;
-                var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };
+                var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };
                 HandleGitStatusCacheUpdatedEvent(updateEvent);
             }
         }
@@ -158,32 +158,31 @@ public void CheckCurrentBranchAndRemoteChangedEvent(CacheUpdateEvent cacheUpdate
         private void CheckRepositoryInfoCacheEvent(CacheUpdateEvent cacheUpdateEvent)
         {
             var managedCache = cacheContainer.RepositoryInfoCache;
-            var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);
+            var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;
 
             Logger.Trace("Check RepositoryInfoCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,
-                cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);
+                cacheUpdateEvent.UpdatedTime, raiseEvent);
 
             if (raiseEvent)
             {
                 var dateTimeOffset = managedCache.LastUpdatedAt;
-                var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };
+                var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset};
                 HandleRepositoryInfoCacheUpdatedEvent(updateEvent);
             }
         }
 
         public void CheckLocksChangedEvent(CacheUpdateEvent cacheUpdateEvent)
         {
-            CacheUpdateEvent cacheUpdateEvent1 = cacheUpdateEvent;
             var managedCache = cacheContainer.GitLocksCache;
-            var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent1);
+            var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;
 
             Logger.Trace("Check GitLocksCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,
-                cacheUpdateEvent1.UpdatedTimeString ?? "[NULL]", raiseEvent);
+                cacheUpdateEvent.UpdatedTime, raiseEvent);
 
             if (raiseEvent)
             {
                 var dateTimeOffset = managedCache.LastUpdatedAt;
-                var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };
+                var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };
                 HandleGitLocksCacheUpdatedEvent(updateEvent);
             }
         }
@@ -238,15 +237,15 @@ public bool Equals(IRepository other)
         private void CheckBranchCacheEvent(CacheUpdateEvent cacheUpdateEvent)
         {
             var managedCache = cacheContainer.BranchCache;
-            var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);
+            var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;
 
             Logger.Trace("Check BranchCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,
-                cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);
+                cacheUpdateEvent.UpdatedTime, raiseEvent);
 
             if (raiseEvent)
             {
                 var dateTimeOffset = managedCache.LastUpdatedAt;
-                var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };
+                var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };
                 HandleBranchCacheUpdatedEvent(updateEvent);
             }
         }
@@ -283,7 +282,7 @@ private void CacheContainer_OnCacheInvalidated(CacheType cacheType)
 
         private void CacheContainer_OnCacheUpdated(CacheType cacheType, DateTimeOffset offset)
         {
-            var cacheUpdateEvent = new CacheUpdateEvent { UpdatedTimeString = offset.ToString() };
+            var cacheUpdateEvent = new CacheUpdateEvent { UpdatedTime = offset };
             switch (cacheType)
             {
                 case CacheType.BranchCache:
@@ -587,15 +586,15 @@ public User(ICacheContainer cacheContainer)
         public void CheckUserChangedEvent(CacheUpdateEvent cacheUpdateEvent)
         {
             var managedCache = cacheContainer.GitUserCache;
-            var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);
+            var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;
 
             Logger.Trace("Check GitUserCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,
-                cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);
+                cacheUpdateEvent.UpdatedTime, raiseEvent);
 
             if (raiseEvent)
             {
                 var dateTimeOffset = managedCache.LastUpdatedAt;
-                var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };
+                var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };
                 HandleUserCacheUpdatedEvent(updateEvent);
             }
         }
@@ -642,7 +641,7 @@ private void GitUserCacheOnCacheUpdated(DateTimeOffset timeOffset)
         {
             HandleUserCacheUpdatedEvent(new CacheUpdateEvent
             {
-                UpdatedTimeString = timeOffset.ToString()
+                UpdatedTime = timeOffset
             });
         }
 
@@ -654,7 +653,7 @@ private void GitUserCacheOnCacheInvalidated()
 
         private void HandleUserCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
         {
-            Logger.Trace("GitUserCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
+            Logger.Trace("GitUserCache Updated {0}", cacheUpdateEvent.UpdatedTime);
             Changed?.Invoke(cacheUpdateEvent);
         }
 
@@ -682,6 +681,39 @@ private void UpdateUserAndEmail()
     [Serializable]
     public struct CacheUpdateEvent
     {
-        public string UpdatedTimeString;
+        [NonSerialized] private DateTimeOffset? updatedTimeValue;
+        public string updatedTimeString;
+
+        public DateTimeOffset UpdatedTime
+        {
+            get
+            {
+                if (!updatedTimeValue.HasValue)
+                {
+                    DateTimeOffset result;
+                    if (DateTimeOffset.TryParseExact(updatedTimeString, Constants.Iso8601Format, CultureInfo.InvariantCulture, DateTimeStyles.None, out result))
+                    {
+                        updatedTimeValue = result;
+                    }
+                    else
+                    {
+                        UpdatedTime = DateTimeOffset.MinValue;
+                    }
+                }
+
+                return updatedTimeValue.Value;
+            }
+            set
+            {
+                updatedTimeValue = value;
+                UpdatedTimeString = value.ToString(Constants.Iso8601Format);
+            }
+        }
+
+        public string UpdatedTimeString
+        {
+            get { return updatedTimeString; }
+            private set { updatedTimeString = value; }
+        }
     }
 }
diff --git a/src/GitHub.Api/GitHub.Api.csproj b/src/GitHub.Api/GitHub.Api.csproj
@@ -103,7 +103,6 @@
     <Compile Include="Application\Organization.cs" />
     <Compile Include="Cache\CacheInterfaces.cs" />
     <Compile Include="Extensions\ListExtensions.cs" />
-    <Compile Include="Git\ManagedCacheExtensions.cs" />
     <Compile Include="Git\Tasks\GitLfsVersionTask.cs" />
     <Compile Include="Git\Tasks\GitVersionTask.cs" />
     <Compile Include="Git\ValidateGitInstallResult.cs" />
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs
@@ -210,7 +210,7 @@ public DateTimeOffset LastUpdatedAt
                     }
                     else
                     {
-                        lastUpdatedAtValue = DateTimeOffset.MinValue;
+                        LastUpdatedAt = DateTimeOffset.MinValue;
                     }
                 }
 
@@ -238,7 +238,7 @@ public DateTimeOffset LastVerifiedAt
                     }
                     else
                     {
-                        lastVerifiedAtValue = DateTimeOffset.MinValue;
+                        LastVerifiedAt = DateTimeOffset.MinValue;
                     }
                 }
 
@@ -264,7 +264,7 @@ public DateTimeOffset InitializedAt
                     }
                     else
                     {
-                        initializedAtValue = DateTimeOffset.MinValue;
+                        InitializedAt = DateTimeOffset.MinValue;
                     }
                 }
 
@@ -414,9 +414,9 @@ public ConfigRemoteDictionary(IDictionary<string, ConfigRemote> dictionary)
     [Location("cache/repoinfo.yaml", LocationAttribute.Location.LibraryFolder)]
     sealed class RepositoryInfoCache : ManagedCacheBase<RepositoryInfoCache>, IRepositoryInfoCache
     {
-        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string firstInitializedAtString = DateTimeOffset.MinValue.ToString();
+        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string firstInitializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
         [SerializeField] private GitRemote gitRemote;
         [SerializeField] private GitBranch gitBranch;
 
@@ -501,9 +501,9 @@ sealed class BranchCache : ManagedCacheBase<BranchCache>, IBranchCache
         public static readonly ConfigBranch DefaultConfigBranch = new ConfigBranch();
         public static readonly ConfigRemote DefaultConfigRemote = new ConfigRemote();
 
-        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();
+        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
 
         [SerializeField] private ConfigBranch gitConfigBranch;
         [SerializeField] private ConfigRemote gitConfigRemote;
@@ -774,9 +774,9 @@ public override TimeSpan DataTimeout
     [Location("cache/gitlog.yaml", LocationAttribute.Location.LibraryFolder)]
     sealed class GitLogCache : ManagedCacheBase<GitLogCache>, IGitLogCache
     {
-        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();
+        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
         [SerializeField] private List<GitLogEntry> log = new List<GitLogEntry>();
 
         public GitLogCache() : base(true)
@@ -833,9 +833,9 @@ public override TimeSpan DataTimeout
     [Location("cache/gitstatus.yaml", LocationAttribute.Location.LibraryFolder)]
     sealed class GitStatusCache : ManagedCacheBase<GitStatusCache>, IGitStatusCache
     {
-        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();
+        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
         [SerializeField] private GitStatus status;
 
         public GitStatusCache() : base(true)
@@ -892,9 +892,9 @@ public override TimeSpan DataTimeout
     [Location("cache/gitlocks.yaml", LocationAttribute.Location.LibraryFolder)]
     sealed class GitLocksCache : ManagedCacheBase<GitLocksCache>, IGitLocksCache
     {
-        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();
+        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
         [SerializeField] private List<GitLock> gitLocks = new List<GitLock>();
 
         public GitLocksCache() : base(true)
@@ -951,9 +951,9 @@ public override TimeSpan DataTimeout
     [Location("cache/gituser.yaml", LocationAttribute.Location.LibraryFolder)]
     sealed class GitUserCache : ManagedCacheBase<GitUserCache>, IGitUserCache
     {
-        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();
+        [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
+        [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);
         [SerializeField] private string gitName;
         [SerializeField] private string gitEmail;
 

Original file line number	Diff line number	Diff line change
`@@ -111,31 +111,31 @@ public ITask ReleaseLock(string file, bool force)`
`111`	`111`	`public void CheckLogChangedEvent(CacheUpdateEvent cacheUpdateEvent)`
`112`	`112`	`{`
`113`	`113`	`var managedCache = cacheContainer.GitLogCache;`
`114`		`- var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);`
	`114`	`+ var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;`
`115`	`115`
`116`	`116`	`Logger.Trace("Check GitLogCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,`
`117`		`- cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);`
	`117`	`+ cacheUpdateEvent.UpdatedTime, raiseEvent);`
`118`	`118`
`119`	`119`	`if (raiseEvent)`
`120`	`120`	`{`
`121`	`121`	`var dateTimeOffset = managedCache.LastUpdatedAt;`
`122`		`- var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };`
	`122`	`+ var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };`
`123`	`123`	`HandleGitLogCacheUpdatedEvent(updateEvent);`
`124`	`124`	`}`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`public void CheckStatusChangedEvent(CacheUpdateEvent cacheUpdateEvent)`
`128`	`128`	`{`
`129`	`129`	`var managedCache = cacheContainer.GitStatusCache;`
`130`		`- var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);`
	`130`	`+ var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;`
`131`	`131`
`132`	`132`	`Logger.Trace("Check GitStatusCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,`
`133`		`- cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);`
	`133`	`+ cacheUpdateEvent.UpdatedTime, raiseEvent);`
`134`	`134`
`135`	`135`	`if (raiseEvent)`
`136`	`136`	`{`
`137`	`137`	`var dateTimeOffset = managedCache.LastUpdatedAt;`
`138`		`- var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };`
	`138`	`+ var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };`
`139`	`139`	`HandleGitStatusCacheUpdatedEvent(updateEvent);`
`140`	`140`	`}`
`141`	`141`	`}`
`@@ -158,32 +158,31 @@ public void CheckCurrentBranchAndRemoteChangedEvent(CacheUpdateEvent cacheUpdate`
`158`	`158`	`private void CheckRepositoryInfoCacheEvent(CacheUpdateEvent cacheUpdateEvent)`
`159`	`159`	`{`
`160`	`160`	`var managedCache = cacheContainer.RepositoryInfoCache;`
`161`		`- var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);`
	`161`	`+ var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;`
`162`	`162`
`163`	`163`	`Logger.Trace("Check RepositoryInfoCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,`
`164`		`- cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);`
	`164`	`+ cacheUpdateEvent.UpdatedTime, raiseEvent);`
`165`	`165`
`166`	`166`	`if (raiseEvent)`
`167`	`167`	`{`
`168`	`168`	`var dateTimeOffset = managedCache.LastUpdatedAt;`
`169`		`- var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };`
	`169`	`+ var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset};`
`170`	`170`	`HandleRepositoryInfoCacheUpdatedEvent(updateEvent);`
`171`	`171`	`}`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`public void CheckLocksChangedEvent(CacheUpdateEvent cacheUpdateEvent)`
`175`	`175`	`{`
`176`		`- CacheUpdateEvent cacheUpdateEvent1 = cacheUpdateEvent;`
`177`	`176`	`var managedCache = cacheContainer.GitLocksCache;`
`178`		`- var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent1);`
	`177`	`+ var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;`
`179`	`178`
`180`	`179`	`Logger.Trace("Check GitLocksCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,`
`181`		`- cacheUpdateEvent1.UpdatedTimeString ?? "[NULL]", raiseEvent);`
	`180`	`+ cacheUpdateEvent.UpdatedTime, raiseEvent);`
`182`	`181`
`183`	`182`	`if (raiseEvent)`
`184`	`183`	`{`
`185`	`184`	`var dateTimeOffset = managedCache.LastUpdatedAt;`
`186`		`- var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };`
	`185`	`+ var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };`
`187`	`186`	`HandleGitLocksCacheUpdatedEvent(updateEvent);`
`188`	`187`	`}`
`189`	`188`	`}`
`@@ -238,15 +237,15 @@ public bool Equals(IRepository other)`
`238`	`237`	`private void CheckBranchCacheEvent(CacheUpdateEvent cacheUpdateEvent)`
`239`	`238`	`{`
`240`	`239`	`var managedCache = cacheContainer.BranchCache;`
`241`		`- var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);`
	`240`	`+ var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;`
`242`	`241`
`243`	`242`	`Logger.Trace("Check BranchCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,`
`244`		`- cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);`
	`243`	`+ cacheUpdateEvent.UpdatedTime, raiseEvent);`
`245`	`244`
`246`	`245`	`if (raiseEvent)`
`247`	`246`	`{`
`248`	`247`	`var dateTimeOffset = managedCache.LastUpdatedAt;`
`249`		`- var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };`
	`248`	`+ var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };`
`250`	`249`	`HandleBranchCacheUpdatedEvent(updateEvent);`
`251`	`250`	`}`
`252`	`251`	`}`
`@@ -283,7 +282,7 @@ private void CacheContainer_OnCacheInvalidated(CacheType cacheType)`
`283`	`282`
`284`	`283`	`private void CacheContainer_OnCacheUpdated(CacheType cacheType, DateTimeOffset offset)`
`285`	`284`	`{`
`286`		`- var cacheUpdateEvent = new CacheUpdateEvent { UpdatedTimeString = offset.ToString() };`
	`285`	`+ var cacheUpdateEvent = new CacheUpdateEvent { UpdatedTime = offset };`
`287`	`286`	`switch (cacheType)`
`288`	`287`	`{`
`289`	`288`	`case CacheType.BranchCache:`
`@@ -587,15 +586,15 @@ public User(ICacheContainer cacheContainer)`
`587`	`586`	`public void CheckUserChangedEvent(CacheUpdateEvent cacheUpdateEvent)`
`588`	`587`	`{`
`589`	`588`	`var managedCache = cacheContainer.GitUserCache;`
`590`		`- var raiseEvent = managedCache.IsLastUpdatedTimeDifferent(cacheUpdateEvent);`
	`589`	`+ var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;`
`591`	`590`
`592`	`591`	`Logger.Trace("Check GitUserCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,`
`593`		`- cacheUpdateEvent.UpdatedTimeString ?? "[NULL]", raiseEvent);`
	`592`	`+ cacheUpdateEvent.UpdatedTime, raiseEvent);`
`594`	`593`
`595`	`594`	`if (raiseEvent)`
`596`	`595`	`{`
`597`	`596`	`var dateTimeOffset = managedCache.LastUpdatedAt;`
`598`		`- var updateEvent = new CacheUpdateEvent { UpdatedTimeString = dateTimeOffset.ToString() };`
	`597`	`+ var updateEvent = new CacheUpdateEvent { UpdatedTime = dateTimeOffset };`
`599`	`598`	`HandleUserCacheUpdatedEvent(updateEvent);`
`600`	`599`	`}`
`601`	`600`	`}`
`@@ -642,7 +641,7 @@ private void GitUserCacheOnCacheUpdated(DateTimeOffset timeOffset)`
`642`	`641`	`{`
`643`	`642`	`HandleUserCacheUpdatedEvent(new CacheUpdateEvent`
`644`	`643`	`{`
`645`		`- UpdatedTimeString = timeOffset.ToString()`
	`644`	`+ UpdatedTime = timeOffset`
`646`	`645`	`});`
`647`	`646`	`}`
`648`	`647`
`@@ -654,7 +653,7 @@ private void GitUserCacheOnCacheInvalidated()`
`654`	`653`
`655`	`654`	`private void HandleUserCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)`
`656`	`655`	`{`
`657`		`- Logger.Trace("GitUserCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);`
	`656`	`+ Logger.Trace("GitUserCache Updated {0}", cacheUpdateEvent.UpdatedTime);`
`658`	`657`	`Changed?.Invoke(cacheUpdateEvent);`
`659`	`658`	`}`
`660`	`659`
`@@ -682,6 +681,39 @@ private void UpdateUserAndEmail()`
`682`	`681`	`[Serializable]`
`683`	`682`	`public struct CacheUpdateEvent`
`684`	`683`	`{`
`685`		`- public string UpdatedTimeString;`
	`684`	`+ [NonSerialized] private DateTimeOffset? updatedTimeValue;`
	`685`	`+ public string updatedTimeString;`
	`686`	`+`
	`687`	`+ public DateTimeOffset UpdatedTime`
	`688`	`+ {`
	`689`	`+ get`
	`690`	`+ {`
	`691`	`+ if (!updatedTimeValue.HasValue)`
	`692`	`+ {`
	`693`	`+ DateTimeOffset result;`
	`694`	`+ if (DateTimeOffset.TryParseExact(updatedTimeString, Constants.Iso8601Format, CultureInfo.InvariantCulture, DateTimeStyles.None, out result))`
	`695`	`+ {`
	`696`	`+ updatedTimeValue = result;`
	`697`	`+ }`
	`698`	`+ else`
	`699`	`+ {`
	`700`	`+ UpdatedTime = DateTimeOffset.MinValue;`
	`701`	`+ }`
	`702`	`+ }`
	`703`	`+`
	`704`	`+ return updatedTimeValue.Value;`
	`705`	`+ }`
	`706`	`+ set`
	`707`	`+ {`
	`708`	`+ updatedTimeValue = value;`
	`709`	`+ UpdatedTimeString = value.ToString(Constants.Iso8601Format);`
	`710`	`+ }`
	`711`	`+ }`
	`712`	`+`
	`713`	`+ public string UpdatedTimeString`
	`714`	`+ {`
	`715`	`+ get { return updatedTimeString; }`
	`716`	`+ private set { updatedTimeString = value; }`
	`717`	`+ }`
`686`	`718`	`}`
`687`	`719`	`}`
Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ public DateTimeOffset LastUpdatedAt`
`210`	`210`	`}`
`211`	`211`	`else`
`212`	`212`	`{`
`213`		`- lastUpdatedAtValue = DateTimeOffset.MinValue;`
	`213`	`+ LastUpdatedAt = DateTimeOffset.MinValue;`
`214`	`214`	`}`
`215`	`215`	`}`
`216`	`216`
`@@ -238,7 +238,7 @@ public DateTimeOffset LastVerifiedAt`
`238`	`238`	`}`
`239`	`239`	`else`
`240`	`240`	`{`
`241`		`- lastVerifiedAtValue = DateTimeOffset.MinValue;`
	`241`	`+ LastVerifiedAt = DateTimeOffset.MinValue;`
`242`	`242`	`}`
`243`	`243`	`}`
`244`	`244`
`@@ -264,7 +264,7 @@ public DateTimeOffset InitializedAt`
`264`	`264`	`}`
`265`	`265`	`else`
`266`	`266`	`{`
`267`		`- initializedAtValue = DateTimeOffset.MinValue;`
	`267`	`+ InitializedAt = DateTimeOffset.MinValue;`
`268`	`268`	`}`
`269`	`269`	`}`
`270`	`270`
`@@ -414,9 +414,9 @@ public ConfigRemoteDictionary(IDictionary<string, ConfigRemote> dictionary)`
`414`	`414`	`[Location("cache/repoinfo.yaml", LocationAttribute.Location.LibraryFolder)]`
`415`	`415`	`sealed class RepositoryInfoCache : ManagedCacheBase<RepositoryInfoCache>, IRepositoryInfoCache`
`416`	`416`	`{`
`417`		`- [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();`
`418`		`- [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();`
`419`		`- [SerializeField] private string firstInitializedAtString = DateTimeOffset.MinValue.ToString();`
	`417`	`+ [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`418`	`+ [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`419`	`+ [SerializeField] private string firstInitializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
`420`	`420`	`[SerializeField] private GitRemote gitRemote;`
`421`	`421`	`[SerializeField] private GitBranch gitBranch;`
`422`	`422`
`@@ -501,9 +501,9 @@ sealed class BranchCache : ManagedCacheBase<BranchCache>, IBranchCache`
`501`	`501`	`public static readonly ConfigBranch DefaultConfigBranch = new ConfigBranch();`
`502`	`502`	`public static readonly ConfigRemote DefaultConfigRemote = new ConfigRemote();`
`503`	`503`
`504`		`- [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();`
`505`		`- [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();`
`506`		`- [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();`
	`504`	`+ [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`505`	`+ [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`506`	`+ [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
`507`	`507`
`508`	`508`	`[SerializeField] private ConfigBranch gitConfigBranch;`
`509`	`509`	`[SerializeField] private ConfigRemote gitConfigRemote;`
`@@ -774,9 +774,9 @@ public override TimeSpan DataTimeout`
`774`	`774`	`[Location("cache/gitlog.yaml", LocationAttribute.Location.LibraryFolder)]`
`775`	`775`	`sealed class GitLogCache : ManagedCacheBase<GitLogCache>, IGitLogCache`
`776`	`776`	`{`
`777`		`- [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();`
`778`		`- [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();`
`779`		`- [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();`
	`777`	`+ [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`778`	`+ [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`779`	`+ [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
`780`	`780`	`[SerializeField] private List<GitLogEntry> log = new List<GitLogEntry>();`
`781`	`781`
`782`	`782`	`public GitLogCache() : base(true)`
`@@ -833,9 +833,9 @@ public override TimeSpan DataTimeout`
`833`	`833`	`[Location("cache/gitstatus.yaml", LocationAttribute.Location.LibraryFolder)]`
`834`	`834`	`sealed class GitStatusCache : ManagedCacheBase<GitStatusCache>, IGitStatusCache`
`835`	`835`	`{`
`836`		`- [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();`
`837`		`- [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();`
`838`		`- [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();`
	`836`	`+ [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`837`	`+ [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`838`	`+ [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
`839`	`839`	`[SerializeField] private GitStatus status;`
`840`	`840`
`841`	`841`	`public GitStatusCache() : base(true)`
`@@ -892,9 +892,9 @@ public override TimeSpan DataTimeout`
`892`	`892`	`[Location("cache/gitlocks.yaml", LocationAttribute.Location.LibraryFolder)]`
`893`	`893`	`sealed class GitLocksCache : ManagedCacheBase<GitLocksCache>, IGitLocksCache`
`894`	`894`	`{`
`895`		`- [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();`
`896`		`- [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();`
`897`		`- [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();`
	`895`	`+ [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`896`	`+ [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`897`	`+ [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
`898`	`898`	`[SerializeField] private List<GitLock> gitLocks = new List<GitLock>();`
`899`	`899`
`900`	`900`	`public GitLocksCache() : base(true)`
`@@ -951,9 +951,9 @@ public override TimeSpan DataTimeout`
`951`	`951`	`[Location("cache/gituser.yaml", LocationAttribute.Location.LibraryFolder)]`
`952`	`952`	`sealed class GitUserCache : ManagedCacheBase<GitUserCache>, IGitUserCache`
`953`	`953`	`{`
`954`		`- [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();`
`955`		`- [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();`
`956`		`- [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();`
	`954`	`+ [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`955`	`+ [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
	`956`	`+ [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString(Constants.Iso8601Format);`
`957`	`957`	`[SerializeField] private string gitName;`
`958`	`958`	`[SerializeField] private string gitEmail;`
`959`	`959`