Returning a completed task

Author: StanleyGoldman

src/GitHub.Api/Git/Repository.cs

@@ -82,7 +82,7 @@ public ITask SetupRemote(string remote, string remoteUrl)
         public ITask<List<GitLogEntry>> Log()
         {
             if (repositoryManager == null)
-                return new FuncListTask<GitLogEntry>(CancellationToken.None,_ => new List<GitLogEntry>());
+                return new FuncListTask<GitLogEntry>(TaskHelpers.GetCompletedTask(new List<GitLogEntry>()));
 
             return repositoryManager.Log();
         }

src/GitHub.Api/GitHub.Api.csproj

@@ -109,6 +109,7 @@
     <Compile Include="Helpers\Constants.cs" />
     <Compile Include="Cache\IBranchCache.cs" />
     <Compile Include="Helpers\Validation.cs" />
+    <Compile Include="Helpers\TaskHelpers.cs" />
     <Compile Include="Platform\DefaultEnvironment.cs" />
     <Compile Include="Extensions\EnvironmentExtensions.cs" />
     <Compile Include="Extensions\FileEventExtensions.cs" />

src/GitHub.Api/Helpers/TaskHelpers.cs

@@ -0,0 +1,12 @@
+using System.Threading.Tasks;
+
+namespace GitHub.Unity
+{
+    static class TaskHelpers
+    {
+        public static Task<T> GetCompletedTask<T>(T result)
+        {
+            return TaskEx.FromResult(result);
+        }
+    }
+}