Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 6912577

Browse files
committed
Lower web request timeout on tests. Rename tests to explain what they are testing
1 parent c20ac0a commit 6912577

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/tests/IntegrationTests/Download/DownloadTaskTests.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public override void TestFixtureSetUp()
2828
base.TestFixtureSetUp();
2929
server = new TestWebServer.HttpServer(SolutionDirectory.Combine("files"));
3030
Task.Factory.StartNew(server.Start);
31-
ApplicationConfiguration.WebTimeout = 20000;
31+
ApplicationConfiguration.WebTimeout = 5000;
3232
}
3333

3434
public override void TestFixtureTearDown()
@@ -60,7 +60,7 @@ private void StopTrackTimeAndLog(Stopwatch watch, ILogging logger)
6060
}
6161

6262
[Test]
63-
public void TestDownloadTask()
63+
public void ResumingDownloadsWorks()
6464
{
6565
Stopwatch watch;
6666
ILogging logger;
@@ -136,7 +136,7 @@ public void TestDownloadTask()
136136
}
137137

138138
[Test]
139-
public void TestDownloadFailure()
139+
public void DownloadingNonExistingFileThrows()
140140
{
141141
Stopwatch watch;
142142
ILogging logger;
@@ -170,7 +170,7 @@ public void TestDownloadFailure()
170170
}
171171

172172
[Test]
173-
public void TestDownloadTextTask()
173+
public void DownloadingATextFileWorks()
174174
{
175175
Stopwatch watch;
176176
ILogging logger;
@@ -200,15 +200,15 @@ public void TestDownloadTextTask()
200200
}
201201

202202
[Test]
203-
public void TestDownloadTextFailure()
203+
public void DownloadingFromNonExistingDomainThrows()
204204
{
205205
Stopwatch watch;
206206
ILogging logger;
207207
StartTest(out watch, out logger);
208208

209209
var fileSystem = Environment.FileSystem;
210210

211-
var downloadTask = new DownloadTextTask(TaskManager.Token, fileSystem, "https://ggggithub.com/robots.txt");
211+
var downloadTask = new DownloadTextTask(TaskManager.Token, fileSystem, "http://ggggithub.com/robots.txt");
212212
var exceptionThrown = false;
213213

214214
var autoResetEvent = new AutoResetEvent(false);
@@ -228,7 +228,7 @@ public void TestDownloadTextFailure()
228228
}
229229

230230
[Test]
231-
public void TestDownloadFileAndHash()
231+
public void DownloadingAFileWithHashValidationWorks()
232232
{
233233
Stopwatch watch;
234234
ILogging logger;
@@ -269,7 +269,7 @@ public void TestDownloadFileAndHash()
269269
}
270270

271271
[Test]
272-
public void TestDownloadShutdownTimeWhenInterrupted()
272+
public void ShutdownTimeWhenTaskManagerDisposed()
273273
{
274274
Stopwatch watch;
275275
ILogging logger;

0 commit comments

Comments
 (0)