Remove ctor args and overloads that we don't use, disable Defer tests

shana · shana · commit 6cbf7c582f24 · 2017-06-09T20:30:29.000+02:00
diff --git a/src/GitHub.Api/Git/Tasks/GitAddTask.cs b/src/GitHub.Api/Git/Tasks/GitAddTask.cs
@@ -8,8 +8,8 @@ class GitAddTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitAddTask(IEnumerable<string> files,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNull(files, "files");
 
diff --git a/src/GitHub.Api/Git/Tasks/GitBranchCreateTask.cs b/src/GitHub.Api/Git/Tasks/GitBranchCreateTask.cs
@@ -8,8 +8,8 @@ class GitBranchCreateTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitBranchCreateTask(string newBranch, string baseBranch,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(newBranch, "newBranch");
             Guard.ArgumentNotNullOrWhiteSpace(baseBranch, "baseBranch");
diff --git a/src/GitHub.Api/Git/Tasks/GitBranchDeleteTask.cs b/src/GitHub.Api/Git/Tasks/GitBranchDeleteTask.cs
@@ -7,8 +7,8 @@ class GitBranchDeleteTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitBranchDeleteTask(string branch, bool deleteUnmerged,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(branch, "branch");
             arguments = !deleteUnmerged ? $"branch -d {branch}" : $"branch -D {branch}";
diff --git a/src/GitHub.Api/Git/Tasks/GitCommitTask.cs b/src/GitHub.Api/Git/Tasks/GitCommitTask.cs
@@ -8,8 +8,8 @@ class GitCommitTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitCommitTask(string message, string body,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(message, "message");
 
diff --git a/src/GitHub.Api/Git/Tasks/GitConfigGetTask.cs b/src/GitHub.Api/Git/Tasks/GitConfigGetTask.cs
@@ -8,8 +8,8 @@ class GitConfigGetAllTask : ProcessTaskWithListOutput<string>
         private readonly string arguments;
 
         public GitConfigGetAllTask(string key, GitConfigSource configSource,
-            CancellationToken token, BaseOutputListProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleListOutputProcessor(), dependsOn)
+            CancellationToken token, BaseOutputListProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleListOutputProcessor())
         {
             var source = "";
             source +=
@@ -30,8 +30,8 @@ class GitConfigGetTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitConfigGetTask(string key, GitConfigSource configSource,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new FirstNonNullLineOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new FirstNonNullLineOutputProcessor())
         {
             var source = "";
             source +=
diff --git a/src/GitHub.Api/Git/Tasks/GitConfigSetTask.cs b/src/GitHub.Api/Git/Tasks/GitConfigSetTask.cs
@@ -11,8 +11,8 @@ class GitConfigSetTask : ProcessTask<string>
         private string label;
 
         public GitConfigSetTask(string key, string value, GitConfigSource configSource,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             this.value = value;
             var source = "";
diff --git a/src/GitHub.Api/Git/Tasks/GitFetchTask.cs b/src/GitHub.Api/Git/Tasks/GitFetchTask.cs
@@ -9,8 +9,8 @@ class GitFetchTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitFetchTask(string remote,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             var stringBuilder = new StringBuilder();
             stringBuilder.Append("fetch");
diff --git a/src/GitHub.Api/Git/Tasks/GitInitTask.cs b/src/GitHub.Api/Git/Tasks/GitInitTask.cs
@@ -4,8 +4,8 @@ namespace GitHub.Unity
 {
     class GitInitTask : ProcessTask<string>
     {
-        public GitInitTask(CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+        public GitInitTask(CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         { }
 
         public override string Name { get { return "git init"; } }
diff --git a/src/GitHub.Api/Git/Tasks/GitLfsInstallTask.cs b/src/GitHub.Api/Git/Tasks/GitLfsInstallTask.cs
@@ -4,8 +4,8 @@ namespace GitHub.Unity
 {
     class GitLfsInstallTask : ProcessTask<string>
     {
-        public GitLfsInstallTask(CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+        public GitLfsInstallTask(CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         { }
 
         public override string Name { get { return "git lfs install"; } }
diff --git a/src/GitHub.Api/Git/Tasks/GitListBranchesTask.cs b/src/GitHub.Api/Git/Tasks/GitListBranchesTask.cs
@@ -6,8 +6,8 @@ class GitListLocalBranchesTask : ProcessTaskWithListOutput<GitBranch>
     {
         private const string Arguments = "branch -vv";
 
-        public GitListLocalBranchesTask(CancellationToken token, BaseOutputListProcessor<GitBranch> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new BranchListOutputProcessor(), dependsOn)
+        public GitListLocalBranchesTask(CancellationToken token, BaseOutputListProcessor<GitBranch> processor = null)
+            : base(token, processor ?? new BranchListOutputProcessor())
         {
         }
 
diff --git a/src/GitHub.Api/Git/Tasks/GitListLocksTask.cs b/src/GitHub.Api/Git/Tasks/GitListLocksTask.cs
@@ -7,8 +7,8 @@ class GitListLocksTask : ProcessTaskWithListOutput<GitLock>
         private readonly string args;
 
         public GitListLocksTask(IGitObjectFactory gitObjectFactory, bool local,
-            CancellationToken token, BaseOutputListProcessor<GitLock> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new LockOutputProcessor(gitObjectFactory), dependsOn)
+            CancellationToken token, BaseOutputListProcessor<GitLock> processor = null)
+            : base(token, processor ?? new LockOutputProcessor(gitObjectFactory))
         {
             args = "lfs locks";
             if (local)
diff --git a/src/GitHub.Api/Git/Tasks/GitLockTask.cs b/src/GitHub.Api/Git/Tasks/GitLockTask.cs
@@ -8,8 +8,8 @@ class GitLockTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitLockTask(string path,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(path, "path");
             arguments = String.Format("lfs lock \"{0}\"", path);
diff --git a/src/GitHub.Api/Git/Tasks/GitLogTask.cs b/src/GitHub.Api/Git/Tasks/GitLogTask.cs
@@ -5,8 +5,8 @@ namespace GitHub.Unity
     class GitLogTask : ProcessTaskWithListOutput<GitLogEntry>
     {
         public GitLogTask(IGitObjectFactory gitObjectFactory,
-            CancellationToken token, BaseOutputListProcessor<GitLogEntry> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new LogEntryOutputProcessor(gitObjectFactory), dependsOn)
+            CancellationToken token, BaseOutputListProcessor<GitLogEntry> processor = null)
+            : base(token, processor ?? new LogEntryOutputProcessor(gitObjectFactory))
         {
         }
 
diff --git a/src/GitHub.Api/Git/Tasks/GitPullTask.cs b/src/GitHub.Api/Git/Tasks/GitPullTask.cs
@@ -9,8 +9,8 @@ class GitPullTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitPullTask(string remote, string branch,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             var stringBuilder = new StringBuilder();
             stringBuilder.Append("pull");
diff --git a/src/GitHub.Api/Git/Tasks/GitPushTask.cs b/src/GitHub.Api/Git/Tasks/GitPushTask.cs
@@ -7,15 +7,15 @@ class GitPushTask : ProcessTask<string>
     {
         private readonly string arguments;
 
-        public GitPushTask(CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+        public GitPushTask(CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             arguments = "push";
         }
 
         public GitPushTask(string remote, string branch, bool setUpstream,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(remote, "remote");
             Guard.ArgumentNotNullOrWhiteSpace(branch, "branch");
diff --git a/src/GitHub.Api/Git/Tasks/GitRemoteAddTask.cs b/src/GitHub.Api/Git/Tasks/GitRemoteAddTask.cs
@@ -8,8 +8,8 @@ class GitRemoteAddTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitRemoteAddTask(string remote, string url,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(remote, "remote");
             Guard.ArgumentNotNullOrWhiteSpace(url, "url");
diff --git a/src/GitHub.Api/Git/Tasks/GitRemoteBranchDeleteTask.cs b/src/GitHub.Api/Git/Tasks/GitRemoteBranchDeleteTask.cs
@@ -8,8 +8,8 @@ class GitRemoteBranchDeleteTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitRemoteBranchDeleteTask(string remote, string branch,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(remote, "remote");
             Guard.ArgumentNotNullOrWhiteSpace(branch, "branch");
diff --git a/src/GitHub.Api/Git/Tasks/GitRemoteChangeTask.cs b/src/GitHub.Api/Git/Tasks/GitRemoteChangeTask.cs
@@ -8,8 +8,8 @@ class GitRemoteChangeTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitRemoteChangeTask(string remote, string url,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(remote, "remote");
             Guard.ArgumentNotNullOrWhiteSpace(url, "url");
diff --git a/src/GitHub.Api/Git/Tasks/GitRemoteListTask.cs b/src/GitHub.Api/Git/Tasks/GitRemoteListTask.cs
@@ -4,8 +4,8 @@ namespace GitHub.Unity
 {
     class GitRemoteListTask : ProcessTaskWithListOutput<GitRemote>
     {
-        public GitRemoteListTask(CancellationToken token, BaseOutputListProcessor<GitRemote> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new RemoteListOutputProcessor(), dependsOn)
+        public GitRemoteListTask(CancellationToken token, BaseOutputListProcessor<GitRemote> processor = null)
+            : base(token, processor ?? new RemoteListOutputProcessor())
         {
         }
 
diff --git a/src/GitHub.Api/Git/Tasks/GitRemoteRemoveTask.cs b/src/GitHub.Api/Git/Tasks/GitRemoteRemoveTask.cs
@@ -8,8 +8,8 @@ class GitRemoteRemoveTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitRemoteRemoveTask(string remote,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(remote, "remote");
             arguments = String.Format("remote rm {0}", remote);
diff --git a/src/GitHub.Api/Git/Tasks/GitRemoveFromIndexTask.cs b/src/GitHub.Api/Git/Tasks/GitRemoveFromIndexTask.cs
@@ -8,8 +8,8 @@ class GitRemoveFromIndexTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitRemoveFromIndexTask(IEnumerable<string> files,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNull(files, "files");
 
diff --git a/src/GitHub.Api/Git/Tasks/GitStatusTask.cs b/src/GitHub.Api/Git/Tasks/GitStatusTask.cs
@@ -5,8 +5,8 @@ namespace GitHub.Unity
     class GitStatusTask : ProcessTask<GitStatus?>
     {
         public GitStatusTask(IGitObjectFactory gitObjectFactory,
-            CancellationToken token, IOutputProcessor<GitStatus?> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new StatusOutputProcessor(gitObjectFactory), dependsOn)
+            CancellationToken token, IOutputProcessor<GitStatus?> processor = null)
+            : base(token, processor ?? new StatusOutputProcessor(gitObjectFactory))
         {
         }
 
diff --git a/src/GitHub.Api/Git/Tasks/GitSwitchBranchesTask.cs b/src/GitHub.Api/Git/Tasks/GitSwitchBranchesTask.cs
@@ -10,8 +10,8 @@ class GitSwitchBranchesTask : ProcessTask<string>
         private readonly string branch;
 
         public GitSwitchBranchesTask(string branch,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(branch, "branch");
             this.branch = branch;
diff --git a/src/GitHub.Api/Git/Tasks/GitUnlockTask.cs b/src/GitHub.Api/Git/Tasks/GitUnlockTask.cs
@@ -8,8 +8,8 @@ class GitUnlockTask : ProcessTask<string>
         private readonly string arguments;
 
         public GitUnlockTask(string path, bool force,
-            CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)
-            : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)
+            CancellationToken token, IOutputProcessor<string> processor = null)
+            : base(token, processor ?? new SimpleOutputProcessor())
         {
             Guard.ArgumentNotNullOrWhiteSpace(path, "path");
 
diff --git a/src/GitHub.Api/GitClient.cs b/src/GitHub.Api/GitClient.cs
diff --git a/src/GitHub.Api/NewTaskSystem/ActionTask.cs b/src/GitHub.Api/NewTaskSystem/ActionTask.cs
diff --git a/src/GitHub.Api/NewTaskSystem/ProcessTask.cs b/src/GitHub.Api/NewTaskSystem/ProcessTask.cs
diff --git a/src/GitHub.Api/NewTaskSystem/TaskBase.cs b/src/GitHub.Api/NewTaskSystem/TaskBase.cs
diff --git a/src/GitHub.Api/NewTaskSystem/TaskExtensions.cs b/src/GitHub.Api/NewTaskSystem/TaskExtensions.cs
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs
diff --git a/src/tests/TaskSystemIntegrationTests/Tests.cs b/src/tests/TaskSystemIntegrationTests/Tests.cs

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,8 @@ class GitAddTask : ProcessTask<string>`
`8`	`8`	`private readonly string arguments;`
`9`	`9`
`10`	`10`	`public GitAddTask(IEnumerable<string> files,`
`11`		`- CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)`
`12`		`- : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)`
	`11`	`+ CancellationToken token, IOutputProcessor<string> processor = null)`
	`12`	`+ : base(token, processor ?? new SimpleOutputProcessor())`
`13`	`13`	`{`
`14`	`14`	`Guard.ArgumentNotNull(files, "files");`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,8 @@ class GitCommitTask : ProcessTask<string>`
`8`	`8`	`private readonly string arguments;`
`9`	`9`
`10`	`10`	`public GitCommitTask(string message, string body,`
`11`		`- CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)`
`12`		`- : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)`
	`11`	`+ CancellationToken token, IOutputProcessor<string> processor = null)`
	`12`	`+ : base(token, processor ?? new SimpleOutputProcessor())`
`13`	`13`	`{`
`14`	`14`	`Guard.ArgumentNotNullOrWhiteSpace(message, "message");`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,8 @@ namespace GitHub.Unity`
`4`	`4`	`{`
`5`	`5`	`class GitInitTask : ProcessTask<string>`
`6`	`6`	`{`
`7`		`- public GitInitTask(CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)`
`8`		`- : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)`
	`7`	`+ public GitInitTask(CancellationToken token, IOutputProcessor<string> processor = null)`
	`8`	`+ : base(token, processor ?? new SimpleOutputProcessor())`
`9`	`9`	`{ }`
`10`	`10`
`11`	`11`	`public override string Name { get { return "git init"; } }`
Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,8 @@ namespace GitHub.Unity`
`4`	`4`	`{`
`5`	`5`	`class GitLfsInstallTask : ProcessTask<string>`
`6`	`6`	`{`
`7`		`- public GitLfsInstallTask(CancellationToken token, IOutputProcessor<string> processor = null, ITask dependsOn = null)`
`8`		`- : base(token, processor ?? new SimpleOutputProcessor(), dependsOn)`
	`7`	`+ public GitLfsInstallTask(CancellationToken token, IOutputProcessor<string> processor = null)`
	`8`	`+ : base(token, processor ?? new SimpleOutputProcessor())`
`9`	`9`	`{ }`
`10`	`10`
`11`	`11`	`public override string Name { get { return "git lfs install"; } }`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,8 @@ class GitListLocalBranchesTask : ProcessTaskWithListOutput<GitBranch>`
`6`	`6`	`{`
`7`	`7`	`private const string Arguments = "branch -vv";`
`8`	`8`
`9`		`- public GitListLocalBranchesTask(CancellationToken token, BaseOutputListProcessor<GitBranch> processor = null, ITask dependsOn = null)`
`10`		`- : base(token, processor ?? new BranchListOutputProcessor(), dependsOn)`
	`9`	`+ public GitListLocalBranchesTask(CancellationToken token, BaseOutputListProcessor<GitBranch> processor = null)`
	`10`	`+ : base(token, processor ?? new BranchListOutputProcessor())`
`11`	`11`	`{`
`12`	`12`	`}`
`13`	`13`