Fix setting busy flag when tasks are done

Author: shana

src/GitHub.Api/Tasks/ProcessTask.cs

@@ -101,6 +101,8 @@ public void Run()
 
             try
             {
+                if (!Process.StartInfo.Arguments.StartsWith("credential-"))
+                    Logger.Trace($"Running '{Process.StartInfo.FileName} {Process.StartInfo.Arguments}'");
                 Process.Start();
             }
             catch (Win32Exception ex)
@@ -286,20 +288,29 @@ protected override T RunWithReturn(bool success)
                 RaiseOnStart,
                 () =>
                 {
-                    if (outputProcessor != null)
-                        result = outputProcessor.Result;
+                    try
+                    {
+                        if (outputProcessor != null)
+                            result = outputProcessor.Result;
 
-                    if (result == null && !Process.StartInfo.CreateNoWindow && typeof(T) == typeof(string))
-                        result = (T)(object)"Process running";
+                        if (result == null && !Process.StartInfo.CreateNoWindow && typeof(T) == typeof(string))
+                            result = (T)(object)"Process running";
 
-                    RaiseOnEnd(result);
-
-                    if (Errors != null)
-                    {
-                        OnErrorData?.Invoke(Errors);
-                        thrownException = thrownException ?? new ProcessException(this);
-                        if (!RaiseFaultHandlers(thrownException))
+                        if (Errors != null)
+                        {
+                            OnErrorData?.Invoke(Errors);
+                            thrownException = thrownException ?? new ProcessException(this);
                             throw thrownException;
+                        }
+                    }
+                    catch (Exception ex)
+                    {
+                        if (!RaiseFaultHandlers(ex))
+                            throw ex;
+                    }
+                    finally
+                    {
+                        RaiseOnEnd(result);
                     }
                 },
                 (ex, error) =>

src/GitHub.Api/Tasks/TaskBase.cs

@@ -387,24 +387,24 @@ protected virtual void RaiseOnEnd()
             OnEnd?.Invoke(this, !taskFailed, exception);
             if (!taskFailed || exceptionWasHandled)
             {
-                if (continuationOnSuccess == null && continuationOnAlways == null)
+                if (continuationOnSuccess == null)
                     CallFinallyHandler();
-                else if (continuationOnSuccess != null)
+                else
                     SetContinuation(continuationOnSuccess, runOnSuccessOptions);
             }
             else
             {
-                if (continuationOnFailure == null && continuationOnAlways == null)
+                if (continuationOnFailure == null)
                     CallFinallyHandler();
-                else if (continuationOnFailure != null)
+                else
                     SetContinuation(continuationOnFailure, runOnSuccessOptions);
             }
             //Logger.Trace($"Finished {ToString()}");
         }
 
         protected void CallFinallyHandler()
         {
-            finallyHandler?.Invoke(Task.Status == TaskStatus.RanToCompletion);
+            finallyHandler?.Invoke(!taskFailed);
         }
 
         protected virtual bool RaiseFaultHandlers(Exception ex)
@@ -617,9 +617,9 @@ protected virtual void RaiseOnEnd(TResult data)
         {
             this.result = data;
             OnEnd?.Invoke(this, result, !taskFailed, exception);
-            if (continuationOnSuccess == null && continuationOnFailure == null && continuationOnAlways == null)
+            if (continuationOnSuccess == null && continuationOnFailure == null)
             {
-                finallyHandler?.Invoke(Task.Status == TaskStatus.RanToCompletion, result);
+                finallyHandler?.Invoke(!taskFailed, result);
                 CallFinallyHandler();
             }
             else if (continuationOnSuccess != null)