Using from result to avoid spinning threads on completed tasks

shana · shana · commit 6e4bdb508b2b · 2017-09-14T20:35:28.000+02:00
diff --git a/src/GitHub.Api/Git/GitClient.cs b/src/GitHub.Api/Git/GitClient.cs
@@ -175,8 +175,7 @@ public ITask<ValidateGitInstallResult> ValidateGitInstall(string path)
         {
             if (!path.ToNPath().FileExists())
             {
-                return new FuncTask<ValidateGitInstallResult>(cancellationToken, 
-                    () => new ValidateGitInstallResult(false, null, null));
+                return new FuncTask<ValidateGitInstallResult>(TaskEx.FromResult(new ValidateGitInstallResult(false, null, null)));
             }
 
             Version gitVersion = null;

Original file line number	Diff line number	Diff line change
`@@ -175,8 +175,7 @@ public ITask<ValidateGitInstallResult> ValidateGitInstall(string path)`
`175`	`175`	`{`
`176`	`176`	`if (!path.ToNPath().FileExists())`
`177`	`177`	`{`
`178`		`- return new FuncTask<ValidateGitInstallResult>(cancellationToken,`
`179`		`- () => new ValidateGitInstallResult(false, null, null));`
	`178`	`+ return new FuncTask<ValidateGitInstallResult>(TaskEx.FromResult(new ValidateGitInstallResult(false, null, null)));`
`180`	`179`	`}`
`181`	`180`
`182`	`181`	`Version gitVersion = null;`