Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 7720511

Browse files
Adding a date label and attempting to place elements better
1 parent bf48faa commit 7720511

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Styles.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@ class Styles
1414
BroadModeBranchesMinWidth = 200f,
1515
BroadModeBranchesRatio = .4f,
1616
InitialStateAreaWidth = 200f,
17-
LocksEntryHeight = 50f,
18-
LocksSummaryHeight = 8f,
19-
LocksUserHeight = 8f,
17+
LocksEntryHeight = 65f,
18+
LocksSummaryHeight = 5f,
19+
LocksUserHeight = 5f,
20+
LocksDateHeight = 5f,
2021
HistoryEntryHeight = 40f,
2122
HistorySummaryHeight = 16f,
2223
HistoryDetailsHeight = 16f,

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/LocksView.cs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ class LocksControl
4040
[NonSerialized] private GitLockEntry rightClickNextRenderEntry;
4141
[NonSerialized] private int controlId;
4242

43-
private const string FilePathFormatString = "Path: {0}";
44-
private const string UserNameFormatString = "User: {0}";
45-
4643
public int SelectedIndex
4744
{
4845
get { return selectedIndex; }
@@ -107,17 +104,21 @@ private void RenderEntry(Rect entryRect, GitLockEntry entry, int index)
107104
{
108105
var isSelected = index == SelectedIndex;
109106

110-
var iconRect = new Rect(entryRect.x, entryRect.y + Styles.BaseSpacing / 2, 32, 32);
111-
var pathRect = new Rect(entryRect.x + 32, entryRect.y + Styles.BaseSpacing / 2, entryRect.width, Styles.LocksSummaryHeight + Styles.BaseSpacing);
112-
var lastY = pathRect.y + pathRect.height;
113-
var userRect = new Rect(entryRect.x + 32, lastY + Styles.BaseSpacing / 2, entryRect.width, Styles.LocksUserHeight + Styles.BaseSpacing);
107+
var iconRect = new Rect(entryRect.x + Styles.BaseSpacing / 2, entryRect.y + (Styles.LocksEntryHeight - 32) / 2, 32 + Styles.BaseSpacing, 32);
108+
109+
var xIconRectRightSidePadded = iconRect.x + iconRect.width;
110+
111+
var pathRect = new Rect(xIconRectRightSidePadded, entryRect.y + Styles.BaseSpacing / 2, entryRect.width, Styles.LocksSummaryHeight + Styles.BaseSpacing);
112+
var userRect = new Rect(xIconRectRightSidePadded, pathRect.y + pathRect.height + Styles.BaseSpacing / 2, entryRect.width, Styles.LocksUserHeight + Styles.BaseSpacing);
113+
var dateRect = new Rect(xIconRectRightSidePadded, userRect.y + userRect.height + Styles.BaseSpacing / 2, entryRect.width, Styles.LocksDateHeight + Styles.BaseSpacing);
114114

115-
var hasKeyboardFocus = GUIUtility.keyboardControl == controlId;
115+
var hasKeyboardFocus = GUIUtility.keyboardControl == controlId;
116116

117117
Styles.Label.Draw(entryRect, GUIContent.none, false, false, isSelected, hasKeyboardFocus);
118118
Styles.Label.Draw(iconRect, entry.Content, false, false, isSelected, hasKeyboardFocus);
119-
Styles.Label.Draw(pathRect, string.Format(FilePathFormatString, entry.GitLock.Path), false, false, isSelected, hasKeyboardFocus);
120-
Styles.Label.Draw(userRect, string.Format(UserNameFormatString, entry.GitLock.User), false, false, isSelected, hasKeyboardFocus);
119+
Styles.Label.Draw(pathRect, entry.GitLock.Path, false, false, isSelected, hasKeyboardFocus);
120+
Styles.Label.Draw(userRect, entry.GitLock.User, false, false, isSelected, hasKeyboardFocus);
121+
Styles.Label.Draw(dateRect, DateTimeOffset.Now.ToString(), false, false, isSelected, hasKeyboardFocus);
121122
}
122123

123124
private bool HandleInput(Rect rect, GitLockEntry entry, int index, Action<GitLock> singleClick = null,

0 commit comments

Comments
 (0)