Merge pull request #230 from github-for-unity/fixes/227-startup-exceptions

Handle exceptions properly on startup

Author: StanleyGoldman

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -39,20 +39,24 @@ protected void Initialize()
             Logging.TracingEnabled = UserSettings.Get(Constants.TraceLoggingKey, false);
             ProcessManager = new ProcessManager(Environment, Platform.GitEnvironment, CancellationToken);
             Platform.Initialize(ProcessManager, TaskManager);
-            if (Environment.GitExecutablePath != null)
-            {
-                GitClient = new GitClient(Environment, ProcessManager, Platform.CredentialManager, TaskManager);
-            }
+            GitClient = new GitClient(Environment, ProcessManager, Platform.CredentialManager, TaskManager);
             SetupMetrics();
         }
 
-        public virtual async Task Run(bool firstRun)
+        public void Run(bool firstRun)
+        {
+            new ActionTask(SetupGit())
+                .Then(RestartRepository)
+                .ThenInUI(InitializeUI)
+                .Start();
+        }
+
+        private async Task SetupGit()
         {
             Logger.Trace("Run - CurrentDirectory {0}", NPath.CurrentDirectory);
 
             if (Environment.GitExecutablePath == null)
             {
-                GitClient = new GitClient(Environment, ProcessManager, Platform.CredentialManager, TaskManager);
                 Environment.GitExecutablePath = await DetermineGitExecutablePath();
 
                 Logger.Trace("Environment.GitExecutablePath \"{0}\" Exists:{1}", Environment.GitExecutablePath, Environment.GitExecutablePath.FileExists());
@@ -67,8 +71,6 @@ public virtual async Task Run(bool firstRun)
                 }
             }
 
-            RestartRepository();
-            InitializeUI();
         }
 
         public ITask InitializeRepository()

src/GitHub.Api/Application/IApplicationManager.cs

@@ -17,6 +17,8 @@ interface IApplicationManager : IDisposable
         ITaskManager TaskManager { get; }
         IGitClient GitClient { get; }
         IUsageTracker UsageTracker { get; }
+
+        void Run(bool firstRun);
         void RestartRepository();
         ITask InitializeRepository();
     }

src/UnityExtension/Assets/Editor/GitHub.Unity/EntryPoint.cs

@@ -58,7 +58,7 @@ private static void Initialize()
             Logging.LogAdapter = new FileLogAdapter(logPath);
             Logging.Info("Initializing GitHub for Unity version " + ApplicationInfo.Version);
 
-            ((ApplicationManager)ApplicationManager).Run(ApplicationCache.Instance.FirstRun).Forget();
+            ApplicationManager.Run(ApplicationCache.Instance.FirstRun);
         }
 
         private static bool ServerCertificateValidationCallback(object sender, X509Certificate certificate,