Merge pull request #354 from github-for-unity/fixes/disable-selected-asset-history-view

Disabling focusing action in HistoryView

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs

@@ -12,8 +12,6 @@ namespace GitHub.Unity
     [Serializable]
     class HistoryView : Subview
     {
-        private const string HistoryFocusAll = "(All)";
-        private const string HistoryFocusSingle = "Focus: <b>{0}</b>";
         private const string PullButton = "Pull";
         private const string PullButtonCount = "Pull (<b>{0}</b>)";
         private const string PushButton = "Push";
@@ -48,7 +46,6 @@ class HistoryView : Subview
         [NonSerialized] private bool isBusy;
 
         [SerializeField] private Vector2 detailsScroll;
-        [SerializeField] private Object historyTarget;
         [SerializeField] private Vector2 scroll;
         [SerializeField] private string selectionID;
         [SerializeField] private int statusAhead;
@@ -99,10 +96,7 @@ public override void OnRepositoryChanged(IRepository oldRepository)
 
         public override void OnSelectionChange()
         {
-            if (!string.IsNullOrEmpty(AssetDatabase.GetAssetPath(Selection.activeObject)))
-            {
-                historyTarget = Selection.activeObject;
-            }
+
         }
 
         public override void OnGUI()
@@ -215,20 +209,6 @@ public void OnEmbeddedGUI()
             // History toolbar
             GUILayout.BeginHorizontal(EditorStyles.toolbar);
             {
-                // Target indicator / clear button
-                EditorGUI.BeginDisabledGroup(historyTarget == null);
-                {
-                    if (GUILayout.Button(
-                        historyTarget == null ? HistoryFocusAll : String.Format(HistoryFocusSingle, historyTarget.name),
-                        Styles.HistoryToolbarButtonStyle)
-                    )
-                    {
-                        historyTarget = null;
-                        Refresh();
-                    }
-                }
-                EditorGUI.EndDisabledGroup();
-
                 GUILayout.FlexibleSpace();
 
                 if (isPublished)
@@ -431,7 +411,7 @@ private void ScrollTo(int index, float offset = 0f)
 
         private LogEntryState GetEntryState(int index)
         {
-            return historyTarget == null ? (index < statusAhead ? LogEntryState.Local : LogEntryState.Normal) : LogEntryState.Normal;
+            return index < statusAhead ? LogEntryState.Local : LogEntryState.Normal;
         }
 
         /// <summary>