If running bash fails, don't fail the whole chain, ignore the error and continue

shana · shana · commit 7b08073c3604 · 2018-04-03T20:37:02.000+02:00
diff --git a/src/GitHub.Api/Application/ApplicationManagerBase.cs b/src/GitHub.Api/Application/ApplicationManagerBase.cs
@@ -58,6 +58,7 @@ public void Run(bool firstRun)
             {
                 setExistingEnvironmentPath = new SimpleProcessTask(CancellationToken, "bash".ToNPath(), "-c \"/usr/libexec/path_helper\"")
                            .Configure(ProcessManager, dontSetupGit: true)
+                           .Catch(e => true) // make sure this doesn't throw if the task fails
                            .Then((success, path) => success ? path.Split(new[] { "\"" }, StringSplitOptions.None)[1] : null);
             }
             else

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ public void Run(bool firstRun)`
`58`	`58`	`{`
`59`	`59`	`setExistingEnvironmentPath = new SimpleProcessTask(CancellationToken, "bash".ToNPath(), "-c \"/usr/libexec/path_helper\"")`
`60`	`60`	`.Configure(ProcessManager, dontSetupGit: true)`
	`61`	`+ .Catch(e => true) // make sure this doesn't throw if the task fails`
`61`	`62`	`.Then((success, path) => success ? path.Split(new[] { "\"" }, StringSplitOptions.None)[1] : null);`
`62`	`63`	`}`
`63`	`64`	`else`