Detecting errors properly when downloading

Author: StanleyGoldman

src/GitHub.Api/Tasks/DownloadTask.cs

@@ -85,7 +85,12 @@ public static WebResponse GetResponseWithoutException(this WebRequest request)
             }
             catch (WebException e)
             {
-                return e.Response;
+                if (e.Response != null)
+                {
+                    return e.Response;
+                }
+
+                throw e;
             }
         }
     }

src/tests/IntegrationTests/Download/DownloadTaskTests.cs

@@ -81,7 +81,6 @@ public void TestDownloadFailure()
             exceptionThrown.Should().NotBeNull();
         }
 
-
         [Test]
         public void TestDownloadTextTask()
         {
@@ -92,6 +91,26 @@ public void TestDownloadTextTask()
             var resultLines = result.Split(new[] { '\n' }, StringSplitOptions.RemoveEmptyEntries);
             resultLines[0].Should().Be("# If you would like to crawl GitHub contact us at [email protected].");
         }
+
+        [Test]
+        public void TestDownloadTextFailture()
+        {
+            InitializeTaskManager();
+
+            var downloadTask = new DownloadTextTask(CancellationToken.None, "https://ggggithub.com/robots.txt");
+            var exceptionThrown = false;
+
+            try
+            {
+                var result = downloadTask.Start().Result;
+            }
+            catch (Exception e)
+            {
+                exceptionThrown = true;
+            }
+
+            exceptionThrown.Should().BeTrue();
+        }
 
         [Test]
         public void TestDownloadFileAndHash()