Removing Texture2D objects from cache

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/EntryPoint.cs

@@ -55,13 +55,6 @@ private static ApplicationCache CreateInstance()
         [SerializeField] public bool Initialized;
 
         [SerializeField] public string CreatedDate;
-        [SerializeField] public Texture2D LockedModifiedStatusIcon;
-        [SerializeField] public Texture2D LockedStatusIcon;
-        [SerializeField] public Texture2D ModifiedStatusIcon;
-        [SerializeField] public Texture2D AddedStatusIcon;
-        [SerializeField] public Texture2D DeletedStatusIcon;
-        [SerializeField] public Texture2D RenamedStatusIcon;
-        [SerializeField] public Texture2D UntrackedStatusIcon;
 
         public void Initialize()
         {

src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Styles.cs

@@ -783,25 +783,25 @@ public static Texture2D GetFileStatusIcon(GitFileStatus status, bool isLocked)
                 switch (status)
                 {
                     case GitFileStatus.Modified:
-                        return ApplicationCache.Instance.LockedModifiedStatusIcon = ApplicationCache.Instance.LockedModifiedStatusIcon ?? Utility.GetIcon("locked.png", "[email protected]");
+                        return Utility.GetIcon("locked.png", "[email protected]");
 
                     default:
-                        return ApplicationCache.Instance.LockedStatusIcon = ApplicationCache.Instance.LockedStatusIcon ?? Utility.GetIcon("locked-by-person.png", "[email protected]");
+                        return Utility.GetIcon("locked-by-person.png", "[email protected]");
                 }
             }
 
             switch (status)
             {
                 case GitFileStatus.Modified:
-                    return ApplicationCache.Instance.ModifiedStatusIcon = ApplicationCache.Instance.ModifiedStatusIcon ?? Utility.GetIcon("modified.png", "[email protected]");
+                    return Utility.GetIcon("modified.png", "[email protected]");
                 case GitFileStatus.Added:
-                    return ApplicationCache.Instance.AddedStatusIcon = ApplicationCache.Instance.AddedStatusIcon ?? Utility.GetIcon("added.png", "[email protected]");
+                    return Utility.GetIcon("added.png", "[email protected]");
                 case GitFileStatus.Deleted:
-                    return ApplicationCache.Instance.DeletedStatusIcon = ApplicationCache.Instance.DeletedStatusIcon ?? Utility.GetIcon("removed.png", "[email protected]");
+                    return Utility.GetIcon("removed.png", "[email protected]");
                 case GitFileStatus.Renamed:
-                    return ApplicationCache.Instance.RenamedStatusIcon = ApplicationCache.Instance.RenamedStatusIcon ?? Utility.GetIcon("renamed.png", "[email protected]");
+                    return Utility.GetIcon("renamed.png", "[email protected]");
                 case GitFileStatus.Untracked:
-                    return ApplicationCache.Instance.UntrackedStatusIcon = ApplicationCache.Instance.UntrackedStatusIcon ?? Utility.GetIcon("untracked.png", "[email protected]");
+                    return Utility.GetIcon("untracked.png", "[email protected]");
             }
 
             return null;