Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 862f680

Browse files
Merge pull request #815 from github-for-unity/fixes/cleanup-build
We really don't need System.Data or System.Xml references
2 parents 41ae437 + 17621b9 commit 862f680

File tree

5 files changed

+1
-35
lines changed

5 files changed

+1
-35
lines changed

src/GitHub.Api/GitHub.Api.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,6 @@
8080
<HintPath>$(SolutionDir).\packages\TaskParallelLibrary.1.0.3333.0\lib\Net35\System.Threading.dll</HintPath>
8181
<Private>True</Private>
8282
</Reference>
83-
<Reference Include="System.Xml.Linq" />
84-
<Reference Include="System.Data.DataSetExtensions" />
85-
<Reference Include="System.Data" />
86-
<Reference Include="System.Xml" />
8783
</ItemGroup>
8884
<ItemGroup>
8985
<Compile Include="Application\ApplicationInfo.cs" />

src/GitHub.Api/Primitives/StringEquivalent.cs

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
using System;
22
using System.Diagnostics.CodeAnalysis;
33
using System.Runtime.Serialization;
4-
using System.Xml;
5-
using System.Xml.Schema;
6-
using System.Xml.Serialization;
74

85
namespace GitHub.Unity
96
{
107
[Serializable]
11-
public abstract class StringEquivalent<T> : ISerializable, IXmlSerializable where T : StringEquivalent<T>
8+
public abstract class StringEquivalent<T> : ISerializable where T : StringEquivalent<T>
129
{
1310
protected string Value;
1411

@@ -86,21 +83,6 @@ public virtual void GetObjectData(SerializationInfo info, StreamingContext conte
8683
info.AddValue("Value", Value);
8784
}
8885

89-
public XmlSchema GetSchema()
90-
{
91-
return null;
92-
}
93-
94-
public void ReadXml(XmlReader reader)
95-
{
96-
Value = reader.ReadString();
97-
}
98-
99-
public void WriteXml(XmlWriter writer)
100-
{
101-
writer.WriteString(Value);
102-
}
103-
10486
public int Length
10587
{
10688
get { return Value != null ? Value.Length : 0; }

src/GitHub.Logging/GitHub.Logging.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@
5353
<ItemGroup>
5454
<Reference Include="System" />
5555
<Reference Include="System.Core" />
56-
<Reference Include="System.Xml.Linq" />
57-
<Reference Include="System.Data.DataSetExtensions" />
58-
<Reference Include="System.Data" />
59-
<Reference Include="System.Xml" />
6056
</ItemGroup>
6157
<ItemGroup>
6258
<Compile Include="Extensions\ExceptionExtensions.cs" />

src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,6 @@
5858
<HintPath>$(SolutionDir)\packages\TaskParallelLibrary.1.0.3333.0\lib\Net35\System.Threading.dll</HintPath>
5959
<Private>True</Private>
6060
</Reference>
61-
<Reference Include="System.Xml.Linq" />
62-
<Reference Include="System.Data.DataSetExtensions" />
63-
<Reference Include="System.Data" />
64-
<Reference Include="System.Xml" />
6561
<Reference Include="UnityEditor">
6662
<HintPath>$(UnityDir)Managed\UnityEditor.dll</HintPath>
6763
<Private>False</Private>

src/UnityExtension/Assets/Editor/UnityTests/UnityTests.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@
4040
</PropertyGroup>
4141
<ItemGroup>
4242
<Reference Include="System" />
43-
<Reference Include="System.Xml" />
44-
<Reference Include="System.Core" />
45-
<Reference Include="System.Runtime.Serialization" />
46-
<Reference Include="System.Xml.Linq" />
4743
<Reference Include="UnityEditor">
4844
<HintPath>$(UnityDir)Managed\UnityEditor.dll</HintPath>
4945
</Reference>

0 commit comments

Comments
 (0)