Fix installer tests

Author: shana

src/GitHub.Api/Helpers/AssemblyResources.cs

@@ -33,7 +33,7 @@ public static NPath ToFile(ResourceType resourceType, string resource, NPath des
             if (stream != null)
                 return destinationPath.Combine(resource).WriteAllBytes(stream.ToByteArray());
 
-            return environment.ExtensionInstallPath.Combine(type, os, resource);
+            return environment.ExtensionInstallPath.Combine(type, os, resource).Copy(destinationPath.Combine(resource));
         }
     }
 }

src/GitHub.Api/Tasks/TaskBase.cs

@@ -51,6 +51,7 @@ public interface ITask : IAsyncResult
         bool IsChainExclusive();
 
         void UpdateProgress(long value, long total, string message = null);
+        ITask GetEndOfChain();
     }
 
     public interface ITask<TResult> : ITask
@@ -192,7 +193,7 @@ public virtual T Then<T>(T nextTask, TaskRunOptions runOptions = TaskRunOptions.
             // if the current task has a fault handler, attach it to the chain we're appending
             if (finallyHandler != null)
             {
-                var endOfChainTask = nextTaskBase.GetBottomMostTask();
+                TaskBase endOfChainTask = (TaskBase)nextTaskBase.GetEndOfChain();
                 while (endOfChainTask != this && endOfChainTask != null)
                 {
                     endOfChainTask.finallyHandler += finallyHandler;
@@ -373,12 +374,12 @@ protected TaskBase GetTopMostTask()
             return depends.GetTopMostTask(null, false);
         }
 
-        protected TaskBase GetBottomMostTask()
+        public ITask GetEndOfChain()
         {
             if (continuationOnSuccess != null)
-                return continuationOnSuccess.GetBottomMostTask();
+                return continuationOnSuccess.GetEndOfChain();
             else if (continuationOnAlways != null)
-                return continuationOnAlways.GetBottomMostTask();
+                return continuationOnAlways.GetEndOfChain();
             return this;
         }
 

src/tests/IntegrationTests/Installer/GitInstallerTests.cs

@@ -50,9 +50,12 @@ public void GitInstallTest()
             TestBasePath.Combine("git").CreateDirectory();
 
             var gitInstaller = new GitInstaller(Environment, CancellationToken.None, installDetails);
-
+            var startTask = gitInstaller.SetupGitIfNeeded();
+            var endTask = new FuncTask<NPath, NPath>(CancellationToken.None, (s, path) => path);
+            startTask.OnEnd += (thisTask, path, success, exception) => thisTask.GetEndOfChain().Then(endTask);
+            startTask.Start();
             NPath? resultPath = null;
-            Assert.DoesNotThrow(async () => resultPath = await gitInstaller.SetupGitIfNeeded().Task);
+            Assert.DoesNotThrow(async () => resultPath = await endTask.Task);
             resultPath.Should().NotBeNull();
         }
     }