Make sure finally always gets called

Author: shana

src/GitHub.Api/Tasks/TaskBase.cs

@@ -213,14 +213,17 @@ public ITask Finally<T>(T taskToContinueWith)
             return continuationOnAlways;
         }
 
+        /// <summary>
+        /// This does not set a dependency between the two tasks. Instead,
+        /// the Start method grabs the state of the previous task to pass on
+        /// to the next task via previousSuccess and previousException
+        /// </summary>
+        /// <param name="handler"></param>
         internal void SetFaultHandler(TaskBase handler)
         {
-            if (Task.Status == TaskStatus.Created)
-                this.continuationOnFailure = handler;
-            else
-                Task.ContinueWith(t => handler.Start(t), Token,
-                    TaskContinuationOptions.OnlyOnFaulted,
-                    TaskManager.GetScheduler(handler.Affinity));
+            Task.ContinueWith(t => handler.Start(t), Token,
+                TaskContinuationOptions.OnlyOnFaulted,
+                TaskManager.GetScheduler(handler.Affinity));
             DependsOn?.SetFaultHandler(handler);
         }
 
@@ -260,6 +263,11 @@ protected void Run()
             }
         }
 
+        /// <summary>
+        /// Call this to run a task after another task is done, without
+        /// having them depend on each other
+        /// </summary>
+        /// <param name="task"></param>
         protected void Start(Task task)
         {
             previousSuccess = task.Status == TaskStatus.RanToCompletion && task.Status != TaskStatus.Faulted;
@@ -365,6 +373,11 @@ protected virtual void RaiseOnEnd()
             //Logger.Trace($"Finished {ToString()}");
         }
 
+        protected void CallFinallyHandler()
+        {
+            finallyHandler?.Invoke();
+        }
+
         protected virtual bool RaiseFaultHandlers(Exception ex)
         {
             if (catchHandler == null)
@@ -565,7 +578,10 @@ protected virtual void RaiseOnEnd(TResult result)
         {
             OnEnd?.Invoke(this, result);
             if (continuationOnSuccess == null && continuationOnFailure == null && continuationOnAlways == null)
+            {
                 finallyHandler?.Invoke(result);
+                CallFinallyHandler();
+            }
             //Logger.Trace($"Finished {ToString()} {result}");
         }