Checking for changes to save in a timely fashion

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/UserSettingsView.cs

@@ -22,6 +22,7 @@ class UserSettingsView : Subview
         [SerializeField] private string gitEmail;
         [SerializeField] private string newGitName;
         [SerializeField] private string newGitEmail;
+        [SerializeField] private bool needsSaving;
 
         public override void InitializeView(IView parent)
         {
@@ -42,11 +43,17 @@ public override void OnGUI()
 
             EditorGUI.BeginDisabledGroup(IsBusy || Parent.IsBusy);
             {
-                newGitName = EditorGUILayout.TextField(GitConfigNameLabel, newGitName);
-                newGitEmail = EditorGUILayout.TextField(GitConfigEmailLabel, newGitEmail);
+                EditorGUI.BeginChangeCheck();
+                {
+                    newGitName = EditorGUILayout.TextField(GitConfigNameLabel, newGitName);
+                    newGitEmail = EditorGUILayout.TextField(GitConfigEmailLabel, newGitEmail);
+                }
 
-                var needsSaving = (newGitName != gitName || newGitEmail != gitEmail)
-                    && !(string.IsNullOrEmpty(newGitName) || string.IsNullOrEmpty(newGitEmail));
+                if (EditorGUI.EndChangeCheck())
+                {
+                    needsSaving = !(string.IsNullOrEmpty(newGitName) || string.IsNullOrEmpty(newGitEmail))
+                        && (newGitName != gitName || newGitEmail != gitEmail);
+                }
 
                 EditorGUI.BeginDisabledGroup(!needsSaving);
                 {
@@ -71,6 +78,8 @@ public override void OnGUI()
                                              gitEmail = newGitEmail;
                                          }
 
+                                         needsSaving = false;
+
                                          Redraw();
                                          Finish(true);
                                      }
@@ -103,6 +112,7 @@ private void MaybeUpdateData()
                 {
                     newGitName = gitName = Repository.User.Name;
                     newGitEmail = gitEmail = Repository.User.Email;
+                    needsSaving = false;
                 }
             }
         }
@@ -127,6 +137,7 @@ private void UpdateUserDataFromClient()
                     {
                         newGitName = gitName = user.Name;
                         newGitEmail = gitEmail = user.Email;
+                        needsSaving = false;
                         Redraw();
                     }
                 }).Start();