Some UnitTest cleanup

Author: StanleyGoldman

src/tests/UnitTests/IO/LinuxBasedGitEnvironmentTests.cs

@@ -10,29 +10,6 @@ namespace UnitTests
     [TestFixture]
     public class LinuxGitEnvironmentTests: GitEnvironmentTestsBase
     {
-        //public static IEnumerable<TestCaseData> GetDefaultGitPath_TestCases()
-        //{
-        //    var testCase = new TestCaseData(true, LinuxGitEnvironment.DefaultGitPath);
-        //    testCase.SetName("Should be found");
-        //    yield return testCase;
-
-        //    testCase = new TestCaseData(false, null);
-        //    testCase.SetName("Should be null");
-        //    yield return testCase;
-        //}
-
-        //[TestCaseSource(nameof(GetDefaultGitPath_TestCases))]
-        //public void GetDefaultGitPath(bool fileFound, string filePath)
-        //{
-        //    var environment = Substitute.For<IEnvironment>();
-
-        //    var filesystem = Substitute.For<IFileSystem>();
-        //    filesystem.FileExists(Args.String).Returns(fileFound);
-
-        //    var linuxBasedGitInstallationStrategy = new LinuxGitEnvironment(environment, filesystem);
-        //    linuxBasedGitInstallationStrategy.FindGitInstallationPath(TODO).Should().Be(filePath);
-        //}
-
         public static IEnumerable<TestCaseData> ValidateGitPath_TestCases()
         {
             var testCase = new TestCaseData(true, true);
@@ -47,8 +24,6 @@ public static IEnumerable<TestCaseData> ValidateGitPath_TestCases()
         [TestCaseSource(nameof(ValidateGitPath_TestCases))]
         public void ValidateGitPath(bool inFileSystem, bool found)
         {
-            var environment = Substitute.For<IEnvironment>();
-
             var filesystem = Substitute.For<IFileSystem>();
             filesystem.FileExists(Args.String).Returns(inFileSystem);
 

src/tests/UnitTests/IO/MacBasedGitEnvironmentTests.cs

@@ -10,29 +10,6 @@ namespace UnitTests
     [TestFixture]
     public class MacGitEnvironmentTests
     {
-        //public static IEnumerable<TestCaseData> GetDefaultGitPath_TestCases()
-        //{
-        //    var testCase = new TestCaseData(true, MacGitEnvironment.DefaultGitPath);
-        //    testCase.SetName("Should be found");
-        //    yield return testCase;
-
-        //    testCase = new TestCaseData(false, null);
-        //    testCase.SetName("Should be null");
-        //    yield return testCase;
-        //}
-
-        //[TestCaseSource(nameof(GetDefaultGitPath_TestCases))]
-        //public void GetDefaultGitPath(bool fileFound, string filePath)
-        //{
-        //    var environment = Substitute.For<IEnvironment>();
-
-        //    var filesystem = Substitute.For<IFileSystem>();
-        //    filesystem.FileExists(Args.String).Returns(fileFound);
-
-        //    var linuxBasedGitInstallationStrategy = new MacGitEnvironment(environment, filesystem);
-        //    linuxBasedGitInstallationStrategy.FindGitInstallationPath(TODO).Should().Be(filePath);
-        //}
-
         public static IEnumerable<TestCaseData> ValidateGitPath_TestCases()
         {
             var testCase = new TestCaseData(true, true);
@@ -47,8 +24,6 @@ public static IEnumerable<TestCaseData> ValidateGitPath_TestCases()
         [TestCaseSource(nameof(ValidateGitPath_TestCases))]
         public void ValidateGitPath(bool inFileSystem, bool found)
         {
-            var environment = Substitute.For<IEnvironment>();
-
             var filesystem = Substitute.For<IFileSystem>();
             filesystem.FileExists(Args.String).Returns(inFileSystem);
 

src/tests/UnitTests/IO/WindowsGitEnvironmentTests.cs

@@ -48,21 +48,6 @@ public static IEnumerable<TestCaseData> GetDefaultGitPath_TestCases()
             yield return testCase;
         }
 
-        //[TestCaseSource(nameof(GetDefaultGitPath_TestCases))]
-        //public void GetDefaultGitPath(string localAppDataPath, string gitHubRootPath, string[] gitHubRootPathChildren, string gitExecutablePath)
-        //{
-        //    var environment = Substitute.For<IEnvironment>();
-        //    environment.GetSpecialFolder(Arg.Is(Environment.SpecialFolder.LocalApplicationData))
-        //        .Returns(localAppDataPath);
-
-        //    var filesystem = Substitute.For<IFileSystem>();
-        //    filesystem.GetDirectories(gitHubRootPath)
-        //        .Returns(gitHubRootPathChildren);
-
-        //    var windowsGitInstallationStrategy = new WindowsGitEnvironment(environment, filesystem);
-        //    windowsGitInstallationStrategy.FindGitInstallationPath(TODO).Should().Be(gitExecutablePath);
-        //}
-
         public static IEnumerable<TestCaseData> ValidateGitPath_TestCases()
         {
             var testCase = new TestCaseData(true, true);
@@ -77,8 +62,6 @@ public static IEnumerable<TestCaseData> ValidateGitPath_TestCases()
         [TestCaseSource(nameof(ValidateGitPath_TestCases))]
         public void ValidateGitPath(bool inFileSystem, bool found)
         {
-            var environment = Substitute.For<IEnvironment>();
-
             var filesystem = Substitute.For<IFileSystem>();
             filesystem.FileExists(Args.String).Returns(inFileSystem);