Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 944eb70

Browse files
We only need to avoid saving the keychain
1 parent b2bc249 commit 944eb70

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/GitHub.Api/Authentication/LoginManager.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,10 @@ public async Task<LoginResultData> Login(
8484
throw new InvalidOperationException("Returned token is null or empty");
8585
}
8686

87+
keychain.SetToken(host, loginResultData.Token);
88+
8789
if (loginResultData.Code == LoginResultCodes.Success)
8890
{
89-
keychain.SetToken(host, loginResultData.Token);
9091
await keychain.Save(host);
9192
}
9293

@@ -109,7 +110,7 @@ public async Task<LoginResultData> ContinueLogin(LoginResultData loginResultData
109110
var host = loginResultData.Host;
110111
var keychainAdapter = keychain.Connect(host);
111112
var username = keychainAdapter.Credential.Username;
112-
var password = loginResultData.Token;
113+
var password = keychainAdapter.Credential.Token;
113114
try
114115
{
115116
logger.Trace("2FA Continue");

0 commit comments

Comments
 (0)