Refactoring Window.MaybeUpdateData

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

@@ -109,19 +109,7 @@ public override void OnDataUpdate()
         {
             base.OnDataUpdate();
 
-            string repoRemote = null;
-            if (MaybeUpdateData(out repoRemote))
-            {
-                repoBranchContent = new GUIContent(repoBranch, Window_RepoBranchTooltip);
-                if (repoUrl != null)
-                {
-                    repoUrlContent = new GUIContent(repoUrl, string.Format(Window_RepoUrlTooltip, repoRemote));
-                }
-                else
-                {
-                    repoUrlContent = new GUIContent(repoUrl, Window_RepoNoUrlTooltip);
-                }
-            }
+            MaybeUpdateData();
 
             if (ActiveView != null)
                 ActiveView.OnDataUpdate();
@@ -198,10 +186,10 @@ private void RefreshOnMainThread()
             new ActionTask(TaskManager.Token, Refresh) { Affinity = TaskAffinity.UI }.Start();
         }
 
-        private bool MaybeUpdateData(out string repoRemote)
+        private void MaybeUpdateData()
         {
-            repoRemote = null;
-            bool repoDataChanged = false;
+            string repoRemote = null;
+            var repoDataChanged = false;
             if (Repository != null)
             {
                 var currentBranchString = (Repository.CurrentBranch.HasValue ? Repository.CurrentBranch.Value.Name : null);
@@ -236,7 +224,18 @@ private bool MaybeUpdateData(out string repoRemote)
                 }
             }
 
-            return repoDataChanged;
+            if (repoDataChanged)
+            {
+                repoBranchContent = new GUIContent(repoBranch, Window_RepoBranchTooltip);
+                if (repoUrl != null)
+                {
+                    repoUrlContent = new GUIContent(repoUrl, string.Format(Window_RepoUrlTooltip, repoRemote));
+                }
+                else
+                {
+                    repoUrlContent = new GUIContent(repoUrl, Window_RepoNoUrlTooltip);
+                }
+            }
         }
 
         private void AttachHandlers(IRepository repository)