Serialize the name and email directly

More rippling changes from the previous implementation attempt

Author: StanleyGoldman

src/GitHub.Api/Cache/CacheInterfaces.cs

@@ -49,7 +49,8 @@ public interface IGitLocksCache : IManagedCache
 
     public interface IGitUserCache : IManagedCache
     {
-        User User { get; set; }
+        string Name { get; set; }
+        string Email { get; set; }
     }
 
     public interface IGitStatusCache : IManagedCache

src/GitHub.Api/Git/Repository.cs

@@ -713,14 +713,14 @@ public override string ToString()
 
         public string Name
         {
-            get { return cacheContainer.GitUserCache.User.Name; }
-            private set { cacheContainer.GitUserCache.User.Name = value; }
+            get { return cacheContainer.GitUserCache.Name; }
+            private set { cacheContainer.GitUserCache.Name = value; }
         }
 
         public string Email
         {
-            get { return cacheContainer.GitUserCache.User.Email; }
-            private set { cacheContainer.GitUserCache.User.Email = value; }
+            get { return cacheContainer.GitUserCache.Email; }
+            private set { cacheContainer.GitUserCache.Email = value; }
         }
 
         private void GitUserCacheOnCacheUpdated(DateTimeOffset timeOffset)
@@ -747,15 +747,12 @@ private void UpdateUserAndEmail()
         {
             Logger.Trace("UpdateUserAndEmail");
 
-            string username = null;
-            string email = null;
-
             gitClient.GetConfigUserAndEmail()
-                .Then((success, value) => {
+                .ThenInUI((success, value) => {
                     if (success)
                     {
-                        username = value.Name;
-                        email = value.Email;
+                        Name = value.Name;
+                        Email = value.Email;
                     }
                 }).Start();
         }

src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs

@@ -1008,28 +1008,53 @@ sealed class GitUserCache : ManagedCacheBase<GitUserCache>, IGitUserCache
         [SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();
         [SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();
         [SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();
-        [SerializeField] private User user;
+        [SerializeField] private string gitName;
+        [SerializeField] private string gitEmail;
 
         public GitUserCache() : base(true)
         { }
 
-        public User User
+        public string Name
         {
             get
             {
                 ValidateData();
-                return user;
+                return gitName;
             }
             set
             {
                 var now = DateTimeOffset.Now;
                 var isUpdated = false;
 
-                Logger.Trace("Updating: {0} user:{1}", now, value);
+                Logger.Trace("Updating: {0} Name:{1}", now, value);
 
-                if (!user.Equals(value))
+                if (!gitName.Equals(value))
                 {
-                    user = value;
+                    gitName = value;
+                    isUpdated = true;
+                }
+
+                SaveData(now, isUpdated);
+            }
+        }
+
+        public string Email
+        {
+            get
+            {
+                ValidateData();
+                return gitEmail;
+            }
+            set
+            {
+                var now = DateTimeOffset.Now;
+                var isUpdated = false;
+
+                Logger.Trace("Updating: {0} Email:{1}", now, value);
+
+                if (!gitEmail.Equals(value))
+                {
+                    gitEmail = value;
                     isUpdated = true;
                 }