Clearing the keychain before we remove the credential (#707)

StanleyGoldman · shana · commit 9ac303a3fab7 · 2018-04-24T20:46:13.000+02:00
* Clearing the keychain before we remove the credential
diff --git a/src/GitHub.Api/Authentication/Keychain.cs b/src/GitHub.Api/Authentication/Keychain.cs
@@ -152,9 +152,10 @@ public async Task Clear(UriString host, bool deleteFromCredentialManager)
 
             Guard.ArgumentNotNull(host, nameof(host));
         
+            RemoveConnection(host);
+
             //clear octokit credentials
             await RemoveCredential(host, deleteFromCredentialManager);
-            RemoveConnection(host);
         }
 
         public async Task Save(UriString host)

Original file line number	Diff line number	Diff line change
`@@ -152,9 +152,10 @@ public async Task Clear(UriString host, bool deleteFromCredentialManager)`
`152`	`152`
`153`	`153`	`Guard.ArgumentNotNull(host, nameof(host));`
`154`	`154`
	`155`	`+ RemoveConnection(host);`
	`156`	`+`
`155`	`157`	`//clear octokit credentials`
`156`	`158`	`await RemoveCredential(host, deleteFromCredentialManager);`
`157`		`- RemoveConnection(host);`
`158`	`159`	`}`
`159`	`160`
`160`	`161`	`public async Task Save(UriString host)`