Always use the full version of the package

Author: shana

common/SolutionInfo.cs

@@ -6,8 +6,8 @@
 using System.Runtime.InteropServices;
 
 [assembly: AssemblyProduct("GitHub for Unity")]
-[assembly: AssemblyVersion(System.AssemblyVersionInformation.Version)]
-[assembly: AssemblyFileVersion(System.AssemblyVersionInformation.Version)]
+[assembly: AssemblyVersion(System.AssemblyVersionInformation.VersionForAssembly)]
+[assembly: AssemblyFileVersion(System.AssemblyVersionInformation.VersionForAssembly)]
 [assembly: AssemblyInformationalVersion(System.AssemblyVersionInformation.Version)]
 [assembly: ComVisible(false)]
 [assembly: AssemblyCompany("GitHub, Inc.")]
@@ -31,6 +31,9 @@
 namespace System
 {
     internal static class AssemblyVersionInformation {
-        internal const string Version = "0.33.1";
+        // this is for the AssemblyVersion and AssemblyVersion attributes, which can't handle alphanumerics
+        internal const string VersionForAssembly = "0.33.1";
+        // Actual real version
+        internal const string Version = "0.33.1-beta";
     }
 }

src/GitHub.Api/Application/ApplicationConfiguration.cs

@@ -5,18 +5,6 @@ namespace GitHub.Unity
     public static class ApplicationConfiguration
     {
         public const int DefaultWebTimeout = 3000;
-
-        static ApplicationConfiguration()
-        {
-            var executingAssembly = typeof(ApplicationConfiguration).Assembly;
-            AssemblyName = executingAssembly.GetName();
-        }
-
-        /// <summary>
-        ///     The currently executing assembly.
-        /// </summary>
-        public static AssemblyName AssemblyName { get; }
-
         public static int WebTimeout { get; set; } = DefaultWebTimeout;
     }
 }

src/GitHub.Api/Metrics/UsageTracker.cs

@@ -37,7 +37,7 @@ public UsageTracker(IMetricsService metricsService, ISettings userSettings,
             this.usageLoader = usageLoader;
             this.metricsService = metricsService;
             this.userId = userId;
-            this.appVersion = ApplicationConfiguration.AssemblyName.Version.ToString();
+            this.appVersion = ApplicationInfo.Version;
             this.unityVersion = unityVersion;
             this.instanceId = instanceId;
 

src/tests/IntegrationTests/Metrics/MetricsTests.cs

@@ -29,7 +29,7 @@ class MetricsTests : BaseIntegrationTest
         public void IncrementMetricsWorks(string measureName)
         {
             var userId = Guid.NewGuid().ToString();
-            var appVersion = ApplicationConfiguration.AssemblyName.Version.ToString();
+            var appVersion = ApplicationInfo.Version;
             var unityVersion = "2017.3f1";
             var instanceId = Guid.NewGuid().ToString();
             var usageLoader = Substitute.For<IUsageLoader>();
@@ -54,7 +54,7 @@ public void LoadingWorks()
         {
             InitializeEnvironment(TestBasePath, false, false);
             var userId = Guid.NewGuid().ToString();
-            var appVersion = ApplicationConfiguration.AssemblyName.Version.ToString();
+            var appVersion = ApplicationInfo.Version;
             var unityVersion = "2017.3f1";
             var instanceId = Guid.NewGuid().ToString();
             var usageStore = new UsageStore();