Temporary changes to ensure we set isBusy to false on the correct thread

Author: StanleyGoldman

src/GitHub.Api/Application/ApiClient.cs

@@ -61,7 +61,15 @@ private async Task LogoutInternal(UriString host)
         public async Task CreateRepository(NewRepository newRepository, Action<Octokit.Repository, Exception> callback, string organization = null)
         {
             Guard.ArgumentNotNull(callback, "callback");
-            await CreateRepositoryInternal(newRepository, callback, organization);
+            try
+            {
+                var repository = await CreateRepositoryInternal(newRepository, organization);
+                callback(repository, null);
+            }
+            catch (Exception e)
+            {
+                callback(null, e);
+            }
         }
 
         public async Task GetOrganizations(Action<IList<Organization>> callback)
@@ -174,16 +182,15 @@ public async Task<bool> ContinueLoginAsync(LoginResult loginResult, Func<LoginRe
             return result.Code == LoginResultCodes.Success;
         }
 
-        private async Task CreateRepositoryInternal(NewRepository newRepository, Action<Octokit.Repository, Exception> callback, string organization)
+        private async Task<Octokit.Repository> CreateRepositoryInternal(NewRepository newRepository, string organization)
         {
             try
             {
                 logger.Trace("Creating repository");
 
                 if (!await EnsureKeychainLoaded())
                 {
-                    callback(null, new Exception("Keychain Not Loaded"));
-                    return;
+                    return null;
                 }
 
                 Octokit.Repository repository;
@@ -201,13 +208,12 @@ private async Task CreateRepositoryInternal(NewRepository newRepository, Action<
                 }
 
                 logger.Trace("Created Repository");
-
-                callback(repository, null);
+                return repository;
             }
             catch (Exception ex)
             {
                 logger.Error(ex, "Error Creating Repository");
-                callback(null, ex);
+                throw;
             }
         }
 

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PUblishView.cs

@@ -74,6 +74,7 @@ private void PopulateView()
                         if (user == null)
                         {
                             Logger.Warning("Unable to get current user");
+                            isBusy = false;
                             return;
                         }
 
@@ -82,24 +83,22 @@ private void PopulateView()
 
                         Logger.Trace("GetOrganizations");
 
-                        Client.GetOrganizations(organizations =>
-                        {
+                        Client.GetOrganizations(organizations => {
                             if (organizations == null)
                             {
                                 Logger.Warning("Unable to get list of organizations");
+                                isBusy = false;
                                 return;
                             }
 
                             Logger.Trace("Loaded {0} organizations", organizations.Count);
 
                             var organizationLogins = organizations
-                                .OrderBy(organization => organization.Login)
-                                .Select(organization => organization.Login);
+                                .OrderBy(organization => organization.Login).Select(organization => organization.Login);
 
                             owners = owners.Union(organizationLogins).ToArray();
+                            isBusy = false;
                         });
-                    }).Finally(task => {
-                        isBusy = false;
                     });
                 }
                 else