Attempting to use LoginManager to run octorun

Author: StanleyGoldman

octorun/bin/octorun

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
 
-console.log("node:", process.argv[0]);
+process.stdout.write("node:", process.argv[0]);
 
 require('../src/bin/app.js');

octorun/src/bin/app-login.js

@@ -9,22 +9,22 @@ commander
 
 if (commander.twoFactor) {
     authentication.handleTwoFactorAuthentication(function (token) {
-        console.log(token);
+        process.stdout.write(token);
         process.exit();
     }, function (err) {
-        console.log(err);
+        process.stdout.write(err);
         process.exit();
     });
 }
 else {
     authentication.handleBasicAuthentication(function (token) {
-        console.log(token);
+        process.stdout.write(token);
         process.exit();
     }, function () {
-        console.log("Must specify two-factor authentication OTP code.");
+        process.stdout.write("Must specify two-factor authentication OTP code.");
         process.exit();
     }, function (err) {
-        console.log(err);
+        process.stdout.write(err);
         process.exit();
     });
 }

octorun/src/bin/app-organizations.js

@@ -9,11 +9,11 @@ commander
 var apiWrapper = new ApiWrapper();
 apiWrapper.getOrgs(function (error, result) {
     if (error) {
-        console.log(error);
+        process.stdout.write(error);
         process.exit(-1);
     }
     else {
-        console.log(result);
+        process.stdout.write(result);
         process.exit();
     }
 });

octorun/src/bin/app-publish.js

@@ -12,7 +12,7 @@ commander
 
 if(!commander.repository)
 {
-    console.log("repository required");
+    process.stdout.write("repository required");
     commander.help();
     process.exit(-1);
     return;
@@ -28,11 +28,11 @@ var apiWrapper = new ApiWrapper();
 apiWrapper.publish(commander.repository, commander.description, private, commander.organization,
     function (error, result) {
         if (error) {
-            console.log(error);
+            process.stdout.write(error);
             process.exit(-1);
         }
         else {
-            console.log(result);
+            process.stdout.write(result);
             process.exit();
         }
     });

octorun/src/bin/app-usage.js

@@ -21,7 +21,7 @@ var options = {
 };
 
 var req = https.request(options, function (res) {
-    console.log('statusCode:', res.statusCode);
+    process.stdout.write('statusCode:', res.statusCode);
 
     res.on('data', function (d) {
         process.stdout.write(d);

octorun/src/bin/app-validate.js

@@ -10,11 +10,11 @@ var apiWrapper = new ApiWrapper();
 
 apiWrapper.verifyUser(function (error, result) {
     if (error) {
-        console.log(error);
+        process.stdout.write(error);
         process.exit(-1);
     }
     else {
-        console.log(result);
+        process.stdout.write(result);
         process.exit();
     }
 });

octorun/src/configuration.js

@@ -1,4 +1,4 @@
-require("dotenv").config();
+require("dotenv").config({silent: true});
 
 var clientId = process.env.OCTOKIT_CLIENT_ID;
 var clientSecret = process.env.OCTOKIT_CLIENT_SECRET;

src/GitHub.Api/Authentication/LoginManager.cs

@@ -259,7 +259,7 @@ private async Task<ApplicationAuthorization> TryLogin(
             string password
         )
         {
-            logger.Info("Login Username:{0} {1}", username, octorunScript);
+            logger.Info("Login Username:{0} Script:{1}", username, octorunScript);
 
             ApplicationAuthorization auth = null;
             var loginTask = new SimpleListProcessTask(taskManager.Token, nodeJsExecutablePath, $"{octorunScript} login");
@@ -270,11 +270,17 @@ string password
                 proc.StandardInput.WriteLine(password);
                 proc.StandardInput.Close();
             };
-            var ret = await loginTask.StartAwait();
 
-            foreach (var result in ret)
+            loginTask.OnEndProcess += proc => {
+                logger.Trace("Exit Code: ", proc.Process.ExitCode);  
+            };
+
+            var ret = (await loginTask.StartAwait()).ToArray();
+
+            for (var index = 0; index < ret.Length; index++)
             {
-                logger.Trace(result);
+                var result = ret[index];
+                logger.Trace("line {0}: {1}", index, result);
             }
 
             throw new Exception("Authentication failed");